AMR NB related query

28 views
Skip to first unread message

Ashok Bhat

unread,
Apr 9, 2014, 12:05:04 PM4/9/14
to android...@googlegroups.com
Hi,
I have following questions on AMR-NB

(a) Is ARM optimization disabled?
AMR Narrow band codec, present in frameworks/av/media/libstagefright/codecs/amrnb, contains some in-line ARM assembly.
For example, common/include/basic_op_arm_gcc_v5.h contains GCC ARM in-line assembly for operations like mul, mac etc.
However these assembly optimizations don't seem to be enabled as PV_ARM_GCC_V5 is not defined anywhere in the project.

(b) Are the unused header files needed?
There are few header files in common/include like l_add.h which are not used anywhere. Are these files needed for something?

(c) Who uses AMR-NB on a standard device?
I believe it is used in voice record and playback applications. Is there some other applications that use AMR-NB on a stock device?

Regards
Ashok

Glenn Kasten

unread,
Apr 10, 2014, 9:36:25 PM4/10/14
to android...@googlegroups.com
a. Try doing a git log and git blame to see why.

b. This might be an upstream project which was imported as-is.
If you think removing the files is an improvement, please suggest via a CL.

c. official Android doc:
unofficial doc, I can't vouch for it:
Reply all
Reply to author
Forward
0 new messages