Update wpa_supplicant to match upstream release

[Michael Evans]

Hey All,

I'm not sure if this is the right place to ask, but I was wondering
what the process was for submitting a patch for updating Android to
match an upstream release of wpa_supplicant. The version that ships in
Lollipop (tested on builds for N5, N6, and N9) is affected by a bug
that prevents devices from connecting to wifi on networks that
incorrectly set descriptor version 3 for frames with descriptor
version 2. The bug has ~150 stars on b.android.com
(https://code.google.com/p/android/issues/detail?id=78702) and has yet
to be acknowledged by a maintainer; I was going to submit a patch to
fix this myself until I saw it was already fixed upstream
(http://w1.fi/cgit/hostap/commit/?id=9f6a7cddc42811883d6035032854089475f2fc65).

What are the steps (if there are any) for people outside Google to
update projects under `external/`?

Thanks,
Michael

[Glenn Kasten]

The general process is described at https://source.android.com/source/submit-patches.html

I am not aware of any special process for external projects.

[enh]

upload a patch.

in this specific case, that patch has already been cherrypicked
internally and will be in a future release. (sadly we're not very good
at ensuring that external projects get maintained in AOSP.)

> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Android Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to android-contr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



--
Elliott Hughes - http://who/enh - http://jessies.org/~enh/
Java i18n/JNI/NIO, or bionic questions? Mail me/drop by/add me as a reviewer.

[Michael Evans]

@Glenn, I wasn't sure either except it does mention this "For most projects under external/, changes should be made upstream and then the Android maintainers informed of the new upstream release containing these changes.". Didn't want to cherry-pick the patch if there was a process for pulling more upstream changes than just that one.

@Elliot, will do for next time :) Thanks for the status update!

[enh]

On Mon, Nov 24, 2014 at 3:15 PM, Michael Evans <bmwr...@gmail.com> wrote:
> @Glenn, I wasn't sure either except it does mention this "For most projects
> under external/, changes should be made upstream and then the Android
> maintainers informed of the new upstream release containing these changes.".
> Didn't want to cherry-pick the patch if there was a process for pulling more
> upstream changes than just that one.

that tends to differ by project. for something like strace we have the
full git history. for llvm we have a squashed history. for other
projects we may just have taken some tarball.

in this particular case, it looks like they have updated
wpa_supplicant to 2.3 internally.

[Michael Evans]

Looks like 2.3 predates this commit, so I followed your advice and put up a patch anyway :) Hope it looks good, this is my first time submitting a change.

Can be found here: https://android-review.googlesource.com/#/c/115893/

[enh]

sorry, that was misleading --- internally there's an update to 2.3 and
on top of that there's a cherrypick of this change.