"Weather-based Campaign Management" script not working.

134 views
Skip to first unread message

nicolas...@cewe.de

unread,
Mar 28, 2019, 12:48:10 PM3/28/19
to Google Ads Scripts Forum

Things I did: 

1. Registered at the openweathermap app, subscribed and got my key. 
2. Downloaded the template spreadsheet and edited campaign and weather rules
3. Created a new script with the source code on that side
4. Update the OPEN_WEATHER_MAP_API_KEY, SPREADSHEET_URL, and TARGETING variables in the script, to be precise (I suspect that the problem lies here): 

- replaced 'INSERT_OPEN_WEATHER_MAP_API_KEY_HERE' in lines 44 and 562 with the key from the openweather map app.
- replaced 'INSERT_SPREADSHEET_URL_HERE' in lines 47 and 547 with the spreadsheet with edited campaign and weather rules. 
- after leaving TARGETING variable in line 53 at "ALL" (the default), I switched to "LOCATION" - don't know if this makes a difference, because it didn't work either way.

5. And of course scheduled it to run hourly. 

What might be an important information is that the script is supposed to run for campaigns that target the Swiss market. While I was able to find the Google geo targeting codes for Switzerland as well as regions and cities in the country, I don't know inhowfar the open weather app works for Europe as well. 

Still, no result, there hasn't been a single adjustment as far as I can tell. 

googleadsscrip...@google.com

unread,
Mar 28, 2019, 3:04:09 PM3/28/19
to adwords-scripts+apn2wqeo44ok6qhb...@googlegroups.com, Google Ads Scripts Forum
Hello,

Can you please reply privately with your CID and script name so I can better investigate the issue?

Thanks,
Matt
Google Ads Scripts Team

--
-- You received this message because you are subscribed to the Google Groups AdWords Scripts Forum group. Please do not reply to this email. To post to this group or unsubscribe please visit https://developers.google.com/adwords/scripts/community.
---
You received this message because you are subscribed to the Google Groups "Google Ads Scripts Forum" group.
To unsubscribe from this group and stop receiving emails from it, send an email to adwords-scripts+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/adwords-scripts/675d497a-9591-484e-a7df-e9501051f3a8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Lehnart, Nicolas

unread,
Apr 1, 2019, 3:29:30 AM4/1/19
to Google Ads Scripts Forum on behalf of googleadsscripts-forumadvisor

Okay, I was just dropping in this morning before I am leaving for a business trip, here are the specifics:


CID: NEU CH Cewe Fotobuch886-312-8734

Script: CFB Wetter

Nicolas Lehnart

Online Marketing Manager

 

CEWE Stiftung & Co. KGaA
Freiburger Straße 20

79427 Eschbach/Breisgau

 

Tel: +49 (7634) 505 171

 

Nicolas...@cewe.de

www.cewe.de

 

 

Nachhaltig erfolgreich

Wir engagieren uns nachhaltig für das Klima. Seit 2016 druckt CEWE zum Beispiel alle Markenprodukte klimaneutral. Mehr zu diesem Thema und unserem weiteren Engagement unter https://company.cewe.de/de/nachhaltigkeit.html.



Von: Google Ads Scripts Forum on behalf of googleadsscripts-forumadvisor <adwords...@googlegroups.com>
Gesendet: Donnerstag, 28. März 2019 20:04:05
An: adwords-scripts+apn2wqeo44ok6qhb...@googlegroups.com
Cc: Google Ads Scripts Forum
Betreff: RE: "Weather-based Campaign Management" script not working.
 
You received this message because you are subscribed to a topic in the Google Groups "Google Ads Scripts Forum" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/adwords-scripts/sxd4Sa_LBUQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to adwords-scrip...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/adwords-scripts/1a0o2hg0000000018s2log000g3r6iy6kmj8c9m60o30c1g68qjicpn%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.



CEWE Stiftung & Co. KGaA mit Sitz in Oldenburg; Registergericht Oldenburg HR B 208214; Persönlich haftende geschäftsführende und vertretungsberechtigte Gesellschafterin:
Neumüller CEWE COLOR Stiftung, Sitz: Oldenburg;
Stiftungsverzeichnis der rechtsfähigen Stiftungen des bürgerlichen Rechts im Bezirk der Regierungsvertretung Oldenburg Nummer 15(034).
Stiftungsvorstand:
Dr. Christian Friege (Vorsitzender), Patrick Berkhouwer, Dr. Reiner Fageth, Carsten Heitkamp, Dr. Olaf Holzkämper, Thomas Mehls, Frank Zweigle
Aufsichtsrat:
Otto Korte (Vorsitzender)
UST ID-Nr. DE815453806; St.-Nr. 64/200/38999; GLN 40 04468 00000 4

googleadsscrip...@google.com

unread,
Apr 1, 2019, 12:30:46 PM4/1/19
to Google Ads Scripts Forum
Hello,

The spreadsheet URL and API key have been inserted in the functions, 'validateAndGetSpreadsheet' and 'validateApiKey', but those functions should not be edited. 

Please change line 547 back to:

if (spreadsheeturl == 'INSERT_SPREADSHEET_URL_HERE') {

and line 562 back to:

if (OPEN_WEATHER_MAP_API_KEY == 'INSERT_OPEN_WEATHER_MAP_API_KEY_HERE') {

Then please re-run the script.

Regards,
Matt
Google Ads Scripts Team

On 04/01/19 03:29:23 adwords...@googlegroups.com wrote:

Okay, I was just dropping in this morning before I am leaving for a business trip, here are the specifics:


CID: NEU CH Cewe Fotobuch886-312-8734

Script: CFB Wetter

Nicolas Lehnart

Online Marketing Manager

 

CEWE Stiftung & Co. KGaA
Freiburger Straße 20

79427 Eschbach/Breisgau

 

Tel: +49 (7634) 505 171

 

Nicolas...@cewe.de

www.cewe.de

 

 

Nachhaltig erfolgreich

Wir engagieren uns nachhaltig für das Klima. Seit 2016 druckt CEWE zum Beispiel alle Markenprodukte klimaneutral. Mehr zu diesem Thema und unserem weiteren Engagement unter https://company.cewe.de/de/nachhaltigkeit.html.



Von: Google Ads Scripts Forum on behalf of googleadsscripts-forumadvisor <adwords-scripts@googlegroups.com>

Gesendet: Donnerstag, 28. März 2019 20:04:05

Cc: Google Ads Scripts Forum
Betreff: RE: "Weather-based Campaign Management" script not working.
Hello,

Can you please reply privately with your CID and script name so I can better investigate the issue?

Thanks,
Matt
Google Ads Scripts Team

To unsubscribe from this group and all its topics, send an email to adwords-scripts+unsubscribe@googlegroups.com.



CEWE Stiftung & Co. KGaA mit Sitz in Oldenburg; Registergericht Oldenburg HR B 208214; Persönlich haftende geschäftsführende und vertretungsberechtigte Gesellschafterin:
Neumüller CEWE COLOR Stiftung, Sitz: Oldenburg;
Stiftungsverzeichnis der rechtsfähigen Stiftungen des bürgerlichen Rechts im Bezirk der Regierungsvertretung Oldenburg Nummer 15(034).
Stiftungsvorstand:
Dr. Christian Friege (Vorsitzender), Patrick Berkhouwer, Dr. Reiner Fageth, Carsten Heitkamp, Dr. Olaf Holzkämper, Thomas Mehls, Frank Zweigle
Aufsichtsrat:
Otto Korte (Vorsitzender)
UST ID-Nr. DE815453806; St.-Nr. 64/200/38999; GLN 40 04468 00000 4

--
-- You received this message because you are subscribed to the Google Groups AdWords Scripts Forum group. Please do not reply to this email. To post to this group or unsubscribe please visit https://developers.google.com/adwords/scripts/community.
---
You received this message because you are subscribed to the Google Groups "Google Ads Scripts Forum" group.
To unsubscribe from this group and stop receiving emails from it, send an email to adwords-scripts+unsubscribe@googlegroups.com.

Lehnart, Nicolas

unread,
Apr 8, 2019, 8:30:15 AM4/8/19
to Google Ads Scripts Forum on behalf of googleadsscripts-forumadvisor

Hello Matt,


thanks a lot, its seems to work now - or at least that's what I hope. 

My (personal) issue with this script is that it isn't entirely clear whether it actually does something or not, since the protocol section shows some activity shows various changes (check screenshot attached), while the change log doesn't display any actual changes (and neither does the changelog in the general UI; at least no changes related to this script). 


Would you please be so kind and doublecheck whether the script is actually doing something? Personally, I have no way to verify this, at least no option I know of.


Sincerely yours and thank you in advance, 

Nicolas Lehnart

Online Marketing Manager

 

CEWE Stiftung & Co. KGaA
Freiburger Straße 20

79427 Eschbach/Breisgau

 

Tel: +49 (7634) 505 171

 

Nicolas...@cewe.de

www.cewe.de

 

 

Nachhaltig erfolgreich

Wir engagieren uns nachhaltig für das Klima. Seit 2016 druckt CEWE zum Beispiel alle Markenprodukte klimaneutral. Mehr zu diesem Thema und unserem weiteren Engagement unter https://company.cewe.de/de/nachhaltigkeit.html.



Von: Google Ads Scripts Forum on behalf of googleadsscripts-forumadvisor <adwords...@googlegroups.com>
Gesendet: Montag, 1. April 2019 18:30:40
An: Google Ads Scripts Forum
Betreff: RE: AW: "Weather-based Campaign Management" script not working.
 
To unsubscribe from this group and all its topics, send an email to adwords-scrip...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/adwords-scripts/08p11g00040000010m24es001l12how6kmj8c9m60o30c1g68qjicpn%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.
protocol log.JPG
change log.JPG

googleadsscrip...@google.com

unread,
Apr 8, 2019, 3:19:52 PM4/8/19
to Google Ads Scripts Forum
Hello Nicolas,

Looking at the script history, it appears you are still receiving the spreadsheet validation error, though the code has no issues -- can you please provide me (myash...@google.com) access to the spreadsheet?

Thanks,
Matt Yashinsky
Google Ads Scripts Team

On 04/08/19 08:29:52 adwords...@googlegroups.com wrote:

Hello Matt,


thanks a lot, its seems to work now - or at least that's what I hope. 

My (personal) issue with this script is that it isn't entirely clear whether it actually does something or not, since the protocol section shows some activity shows various changes (check screenshot attached), while the change log doesn't display any actual changes (and neither does the changelog in the general UI; at least no changes related to this script). 


Would you please be so kind and doublecheck whether the script is actually doing something? Personally, I have no way to verify this, at least no option I know of.


Sincerely yours and thank you in advance, 

Nicolas Lehnart

Online Marketing Manager

 

CEWE Stiftung & Co. KGaA
Freiburger Straße 20

79427 Eschbach/Breisgau

 

Tel: +49 (7634) 505 171

 

Nicolas...@cewe.de

www.cewe.de

 

 

Nachhaltig erfolgreich

Wir engagieren uns nachhaltig für das Klima. Seit 2016 druckt CEWE zum Beispiel alle Markenprodukte klimaneutral. Mehr zu diesem Thema und unserem weiteren Engagement unter https://company.cewe.de/de/nachhaltigkeit.html.



Von: Google Ads Scripts Forum on behalf of googleadsscripts-forumadvisor <adwords-scripts@googlegroups.com>

Gesendet: Montag, 1. April 2019 18:30:40
An: Google Ads Scripts Forum
Betreff: RE: AW: "Weather-based Campaign Management" script not working.
Hello,

The spreadsheet URL and API key have been inserted in the functions, 'validateAndGetSpreadsheet' and 'validateApiKey', but those functions should not be edited. 

Please change line 547 back to:

if (spreadsheeturl == 'INSERT_SPREADSHEET_URL_HERE') {

and line 562 back to:

if (OPEN_WEATHER_MAP_API_KEY == 'INSERT_OPEN_WEATHER_MAP_API_KEY_HERE') {

Then please re-run the script.

Regards,
Matt
Google Ads Scripts Team
To unsubscribe from this group and all its topics, send an email to adwords-scripts+unsubscribe@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages