ViterbiLearning potential bug?

[timandka...@gmail.com]

I am looking at the following loop in the ViterbiLearning class

do // Until convergence or max iterations is reached
{

...
...

} while (convergence.HasConverged);

I unless I am missing something, shouldn't this loop continue

while (!convergence.HasConverged)

or do until (convergence.HasConverged)

[César]

Thanks, you are absolutely right. 

There was a bug with the Viterbi learning convergence check for discrete models. I wrote a fix and also took the opportunity to unify the discrete and continuous Viterbi learning algorithms to reduce the probability of those errors in the future. Unit tests also have been updated. Thanks again for reporting the issue!

Best regards,

Cesar