Wildfly exports otel traces despite sampler-type is set to off

[Mattias Andersson]

I want to disable opentelemetry traces by default to avoid error logs when I develop my application locally. When I deploy the application in prod and have an OTEL collector I enable traces and provide an url to the collector.

In the following example I have a simple jaxrs application with a CDI bean. When CDI is enabled in the deployed war, Wildfly starts to export opentelemetry traces despite sampler-type is set to off.

https://github.com/attiand/wildfly-opentelemetry

Any idea what causes this behavior ? 

/Mattias

[Jason Lee]

I do not off hand, but I’ll look into it.

--
You received this message because you are subscribed to the Google Groups "WildFly" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wildfly+u...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/wildfly/aae9990f-f176-40ad-9e92-a429ed3d69den%40googlegroups.com.

-- 
Jason Lee
Principal Software Engineer
IBM Java Middleware
Java Champion

[Jason Lee]

I have file an issue to track this: https://issues.redhat.com/browse/WFLY-21584

[Mattias Andersson]

Tanks!  /M

[Jason Lee]

Can you paste the full error log(s) you’re seeing?

To view this discussion visit https://groups.google.com/d/msgid/wildfly/871ab4fe-c6dd-4f3a-90e9-f3b9971d920cn%40googlegroups.com.

[Mattias Andersson]

I pushed it to the repo: https://github.com/attiand/wildfly-opentelemetry/blob/main/error.log

[Jason Lee]

OK. I think what you’re seeing there is OpenTelemetery trying to export logs:

(vert.x-eventloop-thread-2) Failed to export LogsRequestMarshalers.

The system appears to be honoring the always_off sampler (if I start up a collector, no spans are exported), but that property doesn’t affect logs or metrics. If you really need to shut down ALL publishing, you’ll need to enable MicroProfile Telemetry, and set the Otel properties (otel.[metrics|logs].exporter=none) via MP Config.

Note that, according to the spec, the Otel SDK is disabled by default in an MP environment, so simply enabling that extension in your local environment may be sufficient to suppress the error logging your seeing in dev.

To view this discussion visit https://groups.google.com/d/msgid/wildfly/ab371133-ea10-4be6-a83f-64614a1039f6n%40googlegroups.com.

[Mattias Andersson]

ok 

If I enable microprofile the exporting stops, se: https://github.com/attiand/wildfly-opentelemetry/blob/main/microprofiletelemetry.cli

If I now set the sampler-type to on I still don’t get any traces. /subsystem=opentelemetry:write-attribute(name=sampler-type, value="on")

If I instead run /system-property=otel.sdk.disabled:add(value=false) Wildfly start exporting

If I now set the sampler-type to off it still exporting: /subsystem=opentelemetry:write-attribute(name=sampler-type, value="off")

Note that I have not checked if Wildfly really exports traces. I have just noted that I get the error log.

Perhaps it would be better to migrate to microprofile-telemetry ?

/Mattias 

[Jason Lee]

Whether or not you enable MP Telemetry is probably going to be a personal preference. All it adds, practically speaking, is the ability to configure OpenTelemetry via MP Config, so you see this kind of finer-grained control via the Otel properties. I think, technically, you can also achieve that by setting system properties as you did for otel.sdk.disabled, but MP Config is probably tidier.

With all that said, if you all you really want is to disable signal publishing in your local environment to avoid connection refused logging, I’d probably just set /system-property=otel.sdk.disabled:add(value=true) in my local environment to keep things as close to production as possible, but that too is a personal preference.

Hope that helps.

To view this discussion visit https://groups.google.com/d/msgid/wildfly/45eb0854-77f5-4b1c-b2c1-2521a4f952d8n%40googlegroups.com.

[Mattias Andersson]

It does, thanks for the feedback!

/Mattias

[Jason Lee]

Great! Glad we got you sorted out. :)

To view this discussion visit https://groups.google.com/d/msgid/wildfly/f4ccd235-1c67-48cb-b39b-4c581578bbf4n%40googlegroups.com.