Link failure if FEAT_PROP_POPUP is defined without FEAT_SPELL or FEAT_QUICKFIX

[John Marriott]

Hi All,

mingw64 (gcc 11.3.0) link fails if FEAT_PROP_POPUP is defined but FEAT_QUICKFIX and FEAT_SPELL are not with this error message:
<snip>
gcc -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO -pipe -march=native -Wall -O3 -fomit-frame-pointer -freg-struct-return -fpie -fPIE  -Wl,-nxcompat,-dynamicbase -municode -s  -o vim.exe objnative/alloc.o objnative/arabic.o objnative/arglist.o objnative/autocmd.o objnative/beval.o objnative/blob.o objnative/blowfish.o objnative/buffer.o objnative/bufwrite.o objnative/change.o objnative/charset.o objnative/cindent.o objnative/clientserver.o objnative/clipboard.o objnative/cmdexpand.o objnative/cmdhist.o objnative/crypt.o objnative/crypt_zip.o objnative/debugger.o objnative/dict.o objnative/diff.o objnative/digraph.o objnative/drawline.o objnative/drawscreen.o objnative/edit.o objnative/eval.o objnative/evalbuffer.o objnative/evalfunc.o objnative/evalvars.o objnative/evalwindow.o objnative/ex_cmds.o objnative/ex_cmds2.o objnative/ex_docmd.o objnative/ex_eval.o objnative/ex_getln.o objnative/fileio.o objnative/filepath.o objnative/findfile.o objnative/float.o objnative/fold.o objnative/getchar.o objnative/gui_xim.o objnative/hardcopy.o objnative/hashtab.o objnative/help.o objnative/highlight.o objnative/if_cscope.o objnative/indent.o objnative/insexpand.o objnative/json.o objnative/list.o objnative/locale.o objnative/main.o objnative/map.o objnative/mark.o objnative/match.o objnative/memfile.o objnative/memline.o objnative/menu.o objnative/message.o objnative/misc1.o objnative/misc2.o objnative/mouse.o objnative/move.o objnative/mbyte.o objnative/normal.o objnative/ops.o objnative/option.o objnative/optionstr.o objnative/os_mswin.o objnative/os_win32.o objnative/pathdef.o objnative/popupmenu.o objnative/popupwin.o objnative/profiler.o objnative/quickfix.o objnative/regexp.o objnative/register.o objnative/scriptfile.o objnative/screen.o objnative/search.o objnative/session.o objnative/sha256.o objnative/sign.o objnative/spell.o objnative/spellfile.o objnative/spellsuggest.o objnative/strings.o objnative/syntax.o objnative/tag.o objnative/term.o objnative/testing.o objnative/textformat.o objnative/textobject.o objnative/textprop.o objnative/time.o objnative/typval.o objnative/ui.o objnative/undo.o objnative/usercmd.o objnative/userfunc.o objnative/version.o objnative/vim9cmds.o objnative/vim9compile.o objnative/vim9execute.o objnative/vim9expr.o objnative/vim9instr.o objnative/vim9script.o objnative/vim9type.o objnative/viminfo.o objnative/winclip.o objnative/window.o objnative/os_w32exe.o objnative/vimres.o objnative/xdiffi.o objnative/xemit.o objnative/xprepare.o objnative/xutils.o objnative/xhistogram.o objnative/xpatience.o objnative/iscygpty.o -lkernel32 -luser32 -lgdi32 -ladvapi32 -lcomdlg32 -lcomctl32 -lnetapi32 -lversion -lole32 -luuid
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe: objnative/popupwin.o:popupwin.c:(.text+0xd96): undefined reference to `ml_append_buf'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe: objnative/popupwin.o:popupwin.c:(.text+0xdf5): undefined reference to `ml_append_buf'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe: objnative/popupwin.o:popupwin.c:(.text+0xe4a): undefined reference to `ml_append_buf'
collect2.exe: error: ld returned 1 exit status
make: *** [Make_cyg_ming.mak:1107: vim.exe] Error 1
make: Target 'all' not remade because of errors.

The attached patch seems to fix it.

Cheers
John

[Bram Moolenaar]

John Marriott wrote:

> mingw64 (gcc 11.3.0) link fails if FEAT_PROP_POPUP is defined but=20

> FEAT_QUICKFIX and FEAT_SPELL are not with this error message:
> <snip>

> gcc -I. -Iproto -DWIN32 -DWINVER=3D0x0603 -D_WIN32_WINNT=3D0x0603=20
> -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO=20
> -pipe -march=3Dnative -Wall -O3 -fomit-frame-pointer -freg-struct-return=20
> -fpie -fPIE -Wl,-nxcompat,-dynamicbase -municode -s=C2=A0 -o vim.exe=20
> objnative/alloc.o objnative/arabic.o objnative/arglist.o=20

[...]

> objnative/xpatience.o objnative/iscygpty.o -lkernel32 -luser32 -lgdi32=20

> -ladvapi32 -lcomdlg32 -lcomctl32 -lnetapi32 -lversion -lole32 -luuid

> d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mi=
> ngw32/11.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:=20
> objnative/popupwin.o:popupwin.c:(.text+0xd96): undefined reference to=20
> `ml_append_buf'
> d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mi=
> ngw32/11.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:=20
> objnative/popupwin.o:popupwin.c:(.text+0xdf5): undefined reference to=20
> `ml_append_buf'
> d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mi=
> ngw32/11.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:=20
> objnative/popupwin.o:popupwin.c:(.text+0xe4a): undefined reference to=20

> `ml_append_buf'
> collect2.exe: error: ld returned 1 exit status
> make: *** [Make_cyg_ming.mak:1107: vim.exe] Error 1
> make: Target 'all' not remade because of errors.
>
> The attached patch seems to fix it.

I'll include it, thanks.

--
hundred-and-one symptoms of being an internet addict:
209. Your house stinks because you haven't cleaned it in a week.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///