After applying patches 9.1.2069 to 9.1.2072, build failure in Normal with Motif

[Tony Mechelynck]

gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MOTIF -O2
-fno-strength-reduce -Wall -Wno-deprecated-declarations -D_REENTRANT
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -o objects/gui.o gui.c
gui.c: In function ‘gui_start’:
gui.c:158:9: error: implicit declaration of function
‘gui_gtk_init_socket_server’ [-Wimplicit-function-declaration]
158 | gui_gtk_init_socket_server();
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:3311: objects/gui.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/root/.build/vim/vim-git/src/shadow-normal'
make: *** [Makefile:2022: reconfig] Error 2
exit status 2
Fri 9 Jan 21:24:39 CET 2026

I suspect a missing #ifdef FEAT_GUI_GTK

My other builds (Huge with GTK3, Tiny with Motif and Tiny with no GUI)
don't get this error.

Best regards,
Tony.

[Christian Brabandt]

Hm, strange. Must have happened by the configure change of patch
v9.1.2072. Patch v9.1.2074 should fix it.

Thanks,
Christian
--
This door is baroquen, please wiggle Handel.
(If I wiggle Handel, will it wiggle Bach?)
-- Found on a door in the MSU music building

[Tony Mechelynck]

On Sat, Jan 10, 2026 at 5:49 PM Christian Brabandt <cbl...@256bit.org> wrote:
>
>
> On Fr, 09 Jan 2026, Tony Mechelynck wrote:
>
> > gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MOTIF -O2
> > -fno-strength-reduce -Wall -Wno-deprecated-declarations -D_REENTRANT
> > -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -o objects/gui.o gui.c
> > gui.c: In function ‘gui_start’:
> > gui.c:158:9: error: implicit declaration of function
> > ‘gui_gtk_init_socket_server’ [-Wimplicit-function-declaration]
> > 158 | gui_gtk_init_socket_server();
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > make[1]: *** [Makefile:3311: objects/gui.o] Error 1
> > make[1]: *** Waiting for unfinished jobs....
> > make[1]: Leaving directory '/root/.build/vim/vim-git/src/shadow-normal'
> > make: *** [Makefile:2022: reconfig] Error 2
> > exit status 2
> > Fri 9 Jan 21:24:39 CET 2026
> >
> > I suspect a missing #ifdef FEAT_GUI_GTK
> >
> > My other builds (Huge with GTK3, Tiny with Motif and Tiny with no GUI)
> > don't get this error.
>
> Hm, strange. Must have happened by the configure change of patch
> v9.1.2072. Patch v9.1.2074 should fix it.
>
> Thanks,
> Christian

Indeed. After applying patches 9.1.2073 to 9.1.2077, including only
one change (by 9.1.2074) in src/gui.c, the problem has disappeared.

Best regards,
Tony.