[vim/vim] More improvement (#7317)

[mattn]

This change will reduce much of the flicker of popupmenu.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/7317

Commit Summary

• More improvement

File Changes

• M src/popupmenu.c (3)

Patch Links:

• https://github.com/vim/vim/pull/7317.patch
• https://github.com/vim/vim/pull/7317.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[Bram Moolenaar]

Hmm, this means the popup menu is only redraw when it resized. Where is it then redrawn if there was no resize?

[Maxim Kim]

I am not sure if this is related to the prev patch of @mattn or not, but console vim on windows has some issue with pmenu redraw:

https://i.imgur.com/rVvoti3.gif

This is YCM plugin with console vim 8.2.2000 (with set nolazyredraw)

[mattn]

@mattn pushed 1 commit.

• f24fcb5 Reduce redrawing of popupnenu

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

[mattn]

Updated patch to reduce redrawing of popupmenu

[mattn]

@mattn pushed 1 commit.

• e9b4880 Reduce redrawing of popupnenu

—
You are receiving this because you are subscribed to this thread.

[Bram Moolenaar]

This causes tests to fail. Perhaps there should be a call to pum_redraw() after the pum_display() in insexpand.c ?

[mattn]

The cause of test fail seems to be timed-out and not related on this change.

[Bram Moolenaar]

It doesn't look like a timeout, e.g. https://travis-ci.org/github/vim/vim/jobs/744424902
On Travis the "huge" tests all fail and the errors are related to the popup menu.

[mattn]

Closed #7317.

[mattn]

I'm try this again.