[vim/vim] Replace "Edit with multiple Vims" with "Edit with Vim using tabpages" (Issue #8404) (#8421)
Michael Soyka
This change only applies to the Windows version of Gvim.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/8421
Commit Summary
- Replace "Edit with multiple Vims" with "Edit with Vim using tabpages"
File Changes
- M src/GvimExt/gvimext.cpp (120)
- M src/GvimExt/gvimext.h (8)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
K.Takata
@k-takata commented on this pull request.
> @@ -613,7 +622,7 @@ STDMETHODIMP CShellExt::QueryContextMenu(HMENU hMenu,
if (cbFiles > 1)
{
mii.wID = idCmd++;
- mii.dwTypeData = _("Edit with &multiple Vims");
+ mii.dwTypeData = _("Edit with Vim using tabpages");
Adding an access key might be better. E.g.:
⬇️ Suggested change- mii.dwTypeData = _("Edit with Vim using tabpages");
+ mii.dwTypeData = _("Edit with Vim using &tabpages");
codecov[bot]
Codecov Report
Merging #8421 (cd071bc) into master (2ac4b25) will decrease coverage by
87.31%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #8421 +/- ## =========================================== - Coverage 89.81% 2.50% -87.32% =========================================== Files 149 147 -2 Lines 167792 162610 -5182 =========================================== - Hits 150707 4068 -146639 - Misses 17085 158542 +141457
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | ? |
|
| huge-gcc-none | ? |
|
| huge-gcc-testgui | ? |
|
| huge-gcc-unittests | 2.50% <ø> (-0.01%) |
⬇️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/float.c | 0.00% <0.00%> (-98.91%) |
⬇️ |
| src/digraph.c | 0.00% <0.00%> (-97.78%) |
⬇️ |
| src/gui_gtk_f.c | 0.00% <0.00%> (-97.54%) |
⬇️ |
| src/match.c | 0.00% <0.00%> (-97.13%) |
⬇️ |
| src/crypt_zip.c | 0.00% <0.00%> (-97.06%) |
⬇️ |
| src/sha256.c | 0.00% <0.00%> (-96.94%) |
⬇️ |
| src/evalbuffer.c | 0.00% <0.00%> (-96.83%) |
⬇️ |
| src/cmdhist.c | 0.00% <0.00%> (-96.63%) |
⬇️ |
| src/debugger.c | 0.00% <0.00%> (-96.62%) |
⬇️ |
| src/libvterm/src/rect.h | 0.00% <0.00%> (-96.56%) |
⬇️ |
| ... and 135 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 2ac4b25...cd071bc. Read the comment docs.
Michael Soyka
@msoyka-of-wharton pushed 1 commit.
- 3c99603 Update src/GvimExt/gvimext.cpp
—
You are receiving this because you are subscribed to this thread.
Michael Soyka
Hi Ken,
I'm obviously not familiar with using github's pull requests and so when I tried to reply to your comment, the reply apparently became a commit in my fork. Shall I cancel my pull request, fix the fork and then resubmit the pull request? If there's a simpler approach, please advise.
Sorry for the trouble.
-mike
K.Takata
Shall I cancel my pull request,
No need to do that.
If you want, you can use git push -f to amend your commits.
mss...@gmail.com
Michael Soyka
@msoyka-of-wharton pushed 1 commit.
- 8a2bee0 Replace "Edit with multiple Vims" with "Edit with Vim using tabpages"
—
You are receiving this because you are subscribed to this thread.
Michael Soyka
Closed #8421.