[vim/vim] Update ms windows build doc (#5471)

[Shane Harper]

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/5471

Commit Summary

• Delete "Building with Terminal support" section from INSTALLpc.txt.
• Delete "There are also instructions for pre-XP systems..." as INSTALLpc.txt no longer has instructions for builiding on pre-Windows XP/MS-DOS.
• Minor corrections.
• INSTALLpc.txt: s/vim81/vim82/g
• INSTALLpc.txt: Correct command to copy runtime/.

File Changes

• M Makefile (12)
• M nsis/README.txt (4)
• M src/INSTALLpc.txt (82)

Patch Links:

• https://github.com/vim/vim/pull/5471.patch
• https://github.com/vim/vim/pull/5471.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[Codecov]

Codecov Report

Merging #5471 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@

##           master    #5471      +/-   ##

==========================================

+ Coverage   82.87%   82.87%   +<.01%     

==========================================

  Files         134      134              

  Lines      147944   147944              

==========================================

+ Hits       122608   122615       +7     

+ Misses      25336    25329       -7

Impacted Files	Coverage Δ
src/terminal.c	81.81% <0%> (-0.04%)	⬇️
src/window.c	88.44% <0%> (+0.13%)	⬆️
src/gui.c	63.63% <0%> (+0.15%)	⬆️
src/if_xcmdsrv.c	86.35% <0%> (+0.17%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ebcba6...63babeb. Read the comment docs.

[Bram Moolenaar]

The paths in Makefile are for the current directory when following the instructions, they are not relative to the Makefile itself.

[Bram Moolenaar]

Why remove the section for "Terminal support"?

[Shane Harper]

Previously the "Terminal support" section had special instructions such as
to download dlls from https://github.com/rprichard/winpty (patch 8.0.0742).

Now there are no special instructions for building the terminal feature on
MS Windows; TERMINAL=yes doesn't even need to be specified as that is the
default.

On Tue, 14 Jan 2020 at 05:26, Bram Moolenaar <notifi...@github.com>
wrote:

> Why remove the section for "Terminal support"?
>
> —

> You are receiving this because you authored the thread.

> Reply to this email directly, view it on GitHub

> <https://github.com/vim/vim/pull/5471?email_source=notifications&email_token=AALIBNTDL53HWJDY5UFDSDTQ5SW47A5CNFSM4KF36OLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZYRDA#issuecomment-573802636>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AALIBNVHO5DXYBSEU5RB6ALQ5SW47ANCNFSM4KF36OLA>
> .

[Shane Harper]

@shaneharper pushed 1 commit.

• 09deb3f Revert changes to paths made in 78bb41f41cc3670c60a03f44bb6b898e87526dc.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

[Bram Moolenaar]

Alright, I'll include it then.

[Bram Moolenaar]

Closed #5471.

[Shane Harper]

I believe

  copy runtime\* vim82

should be replaced by

  xcopy /e runtime\* vim82

in src/INSTALLpc.txt.

The original copy command won't copy subdirectories while "xcopy /e" will.

[Bram Moolenaar]

Shouldn't that be:
xcopy /s runtime\* vim82

--
ARTHUR: You are indeed brave Sir knight, but the fight is mine.
BLACK KNIGHT: Had enough?
ARTHUR: You stupid bastard. You havn't got any arms left.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Shane Harper]

On Tuesday, 21 January 2020 08:38:44 UTC+11, Bram Moolenaar wrote:

Shane Harper wrote:

> I believe
>   copy runtime\* vim82
> should be replaced by
>   xcopy /e runtime\* vim82
> in src/INSTALLpc.txt.
>
> The original copy command won't copy subdirectories while "xcopy /e" will.

Shouldn't that be:
    xcopy /s runtime\* vim82

 

Both "xcopy /s" and "xcopy /e" copy subdirectories - however only "xcopy /e" copies empty directories. (When copying the current runtime directory both "xcopy /s" and "xcopy /e" will effectively do the same thing.) 

[Bram Moolenaar]

Shane Harper wrote:

> > > I believe
> > > copy runtime\* vim82
> > > should be replaced by
> > > xcopy /e runtime\* vim82
> > > in src/INSTALLpc.txt.
> > >
> > > The original copy command won't copy subdirectories while "xcopy /e"
> > will.
> >
> > Shouldn't that be:
> > xcopy /s runtime\* vim82
> >
>
> Both "xcopy /s" and "xcopy /e" copy subdirectories - however only "xcopy
> /e" copies empty directories. (When copying the current runtime directory
> both "xcopy /s" and "xcopy /e" will effectively do the same thing.)

The MS docs say that /e only works in combination with /s. But the docs
might be misleading.

--
Eye have a spelling checker, it came with my PC;
It plainly marks four my revue mistakes I cannot sea.
I've run this poem threw it, I'm sure your please to no,
It's letter perfect in it's weigh, my checker tolled me sew!

[Shane Harper]

On Wednesday, 22 January 2020 08:14:29 UTC+11, Bram Moolenaar wrote:

Shane Harper wrote:

> > > I believe
> > >   copy runtime\* vim82
> > > should be replaced by
> > >   xcopy /e runtime\* vim82
> > > in src/INSTALLpc.txt.
> > >
> > > The original copy command won't copy subdirectories while "xcopy /e"
> > will.
> >
> > Shouldn't that be:
> >     xcopy /s runtime\* vim82
> >
>  
> Both "xcopy /s" and "xcopy /e" copy subdirectories - however only "xcopy
> /e" copies empty directories. (When copying the current runtime directory
> both "xcopy /s" and "xcopy /e" will effectively do the same thing.)

The MS docs say that /e only works in combination with /s.  But the docs
might be misleading.

From "help xcopy" on my PC running Windows 10:

  /E           Copies directories and subdirectories, including empty ones.

                Same as /S /E. May be used to modify /T.

Anyway, "xcopy /s" or "xcopy /e" (or "xcopy /s /e") can be used to copy all of the runtime files.