vim9 - vim 81 patch 271 ":'<,'>s/P" cancels visual mode when P is pressed

[Kenneth Freidank]

Latest build of vim9 visual mode cancels when attempting to substitute text in the visual range selected ":'<,'>s/P". 

Steps to repeat:

1. Use visual mode to select some text (press 'v' and move the cursor with the arrow keys and highlight some text).
2. Press the colon key to get the range command ":'<,'>".
3. Add the substitute key sequence "s/".
4. As soon as you type any character after the forward slash, for example the 'P', the visual highlighting is cleared and substitution on the visual range is no longer possible.  Complete key sequence looks like ":'<,'>s/P"

I traced the bug to v8.1.0271 which also scrambles the screen some when the 'P' is pressed.  The prior commit, v8.1.0270 worked fine.

• git checkout v8.1.0270 works fine
• git checkout v8.1.0271 breaks

Build steps

• $ ./configure --with-features=huge --enable-multibyte --enable-pythoninterp --enable-luainterp --enable-perlinterp --enable-cscope --prefix=/home/solomon/local
• $ make -j5
• $ make install

[Christian Brabandt]

On Sa, 18 Mär 2023, Kenneth Freidank wrote:

> Latest build of vim9 visual mode cancels when attempting to substitute text in
> the visual range selected ":'<,'>s/P". 
>
> Steps to repeat:
>

> 1. Use visual mode to select some text (press 'v' and move the cursor with the

> arrow keys and highlight some text).

> 2. Press the colon key to get the range command ":'<,'>".
> 3. Add the substitute key sequence "s/".
> 4. As soon as you type any character after the forward slash, for example the

> 'P', the visual highlighting is cleared and substitution on the visual
> range is no longer possible.  Complete key sequence looks like ":'<,'>s/P"
>
> I traced the bug to v8.1.0271 which also scrambles the screen some when the 'P'
> is pressed.  The prior commit, v8.1.0270 worked fine.
>
> • git checkout v8.1.0270 works fine
> • git checkout v8.1.0271 breaks

If I understand you correctly, you are just seeing the result of
'incsearch' being applied. However, the marks '< and '> are still valid
and vim will replace in the correct marked region. It's just that you do
no longer see it highlighted, because Vim tries to (helpfully) show you
matches of your pattern.

You can disable this behaviour by setting `:set noincsearch` and then
Vim won't clear the highlighting anymore.


Best,
Christian
--
Die Religion hat der Liebe einen großen Dienst erwiesen, indem sie
sie zur Sünde erklärte.
-- Anatole France