Commit: patch 9.1.0342: tests: test_taglist fails when 'helplang' contains non-english

[Christian Brabandt]

patch 9.1.0342: tests: test_taglist fails when 'helplang' contains non-english

Commit: https://github.com/vim/vim/commit/ae7e61c928b4adaa220e59ecebc75ef630674207
Author: Julio B <julio...@gmail.com>
Date: Tue Apr 16 22:55:04 2024 +0200

patch 9.1.0342: tests: test_taglist fails when 'helplang' contains non-english

Problem: tests: test_taglist fails when 'helplang' contains non-english
Solution: Allow 1 or 2 tagfiles for now (Julio B)

related: #14312
closes: #14566

Signed-off-by: Julio B <julio...@gmail.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/testdir/test_taglist.vim b/src/testdir/test_taglist.vim
index 39e78bcb0..2dd236683 100644
--- a/src/testdir/test_taglist.vim
+++ b/src/testdir/test_taglist.vim
@@ -100,7 +100,10 @@ func Test_tagfiles()

help
let tf = tagfiles()
- call assert_equal(1, len(tf))
+ " if 'helplang includes another language, then we may find
+ " 2 tagfiles (e.g.: for EN and RU)
+ " we may need to adjust this, if further translated help files are included
+ call assert_inrange(1, 2, len(tf))
call assert_equal(fnamemodify(expand('$VIMRUNTIME/doc/tags'), ':p:gs?\?/?'),
\ fnamemodify(tf[0], ':p:gs?\?/?'))
helpclose
diff --git a/src/version.c b/src/version.c
index ba64d8fe1..68b58b0b4 100644
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 342,
/**/
341,
/**/

[shane.qian]

> patch 9.1.0342: tests: test_taglist fails when 'helplang' contains non-english
>
> Commit: https://github.com/vim/vim/commit/ae7e61c928b4adaa220e59ecebc75ef630674207
> Author: Julio B <julio...@gmail.com>
> Date: Tue Apr 16 22:55:04 2024 +0200
>
> patch 9.1.0342: tests: test_taglist fails when 'helplang' contains non-english
>
> Problem: tests: test_taglist fails when 'helplang' contains non-english
> Solution: Allow 1 or 2 tagfiles for now (Julio B)
>
> related: #14312
> closes: #14566
>
> Signed-off-by: Julio B <julio...@gmail.com>
> Signed-off-by: Christian Brabandt <c...@256bit.org>

this patch is wrong, `helplang` it was just I brought it to filter tagfiles,
fail was not when 'helplang' contains non-english, it was fail when it is 'en' too.

--
shane.xb.qian

[Christian Brabandt]

On Mi, 17 Apr 2024, shane.qian wrote:

> this patch is wrong, `helplang` it was just I brought it to filter
> tagfiles, fail was not when 'helplang' contains non-english, it was
> fail when it is 'en' too.

Why would it fail when helplang=en. Vim should then only load a single
tagfile, no?

I have been trying to identify the problem from your PR. Perhaps next
time clearly state what problem you are trying to solve :)

Thanks,
Christian
--
"He was a modest, good-humored boy. It was Oxford that made him insufferable."

[shane qian]

the `clear` problem is in the ticket description: a comment link, which was someone described or complained in another ticket.

seems you did not check that carefully, the problem is there not only 1 tag file.

--

shane.xb.qian

[Christian Brabandt]

How is this: "fix: count tag files on helplang due to tags-ru" clear?
It's obviously not clear, otherwise I wouldn't have mentioned it. So
please spell out explicitly, what the actual problem is, instead of
simply pasting links. I would appreciate this thanks.

Thanks,
Christian
--
This life is yours. Some of it was given to you; the rest, you made yourself.

[shane qian]

the ticket description is the description, not the ticket title, please check that. I am not near my PC, otherwise I should would be glad to spell out to you.

--

shane.xb.qian

[Christian Brabandt]

On Mi, 17 Apr 2024, shane qian wrote:

> the ticket description is the description, not the ticket title, please check
> that. I am not near my PC, otherwise I should would be glad to spell out to
> you.

That description is a link to comment: "fix: #14312 (comment)" in
another issue which was already closed.

That by itself may not be a problem, *if I am able to grasp the problem
clearly*.

In any case, for the benefit of the reader, potential reviewers and
myself, it's always appreciated, if you could summarize the problem and
clearly spell out, what problem you have been observing, what is causing
the issue and how you would suggest to have this fixed.

Thanks,
Christian
--
But it does move!
-- Galileo Galilei

[shane qian]

ok, whatever, it's not my problem or it was not an issue I made it, so you can choose the way whatever you like.

if there suggestion: 

1, my workaround perhaps was better, whatever there were tags-ru, and/or tags-de, etc, it should be no err or no block from that test.

2, to real solution, I may suggest review that check-in code in makefile for tags-ru again, it had made some issues.

that's all.

--

shane.xb.qian