Commit: patch 9.2.0151: blob_from_string() is slow for long strings

1 view
Skip to first unread message

Christian Brabandt

unread,
Mar 13, 2026, 1:47:02 PM (10 days ago) Mar 13
to vim...@googlegroups.com
patch 9.2.0151: blob_from_string() is slow for long strings

Commit: https://github.com/vim/vim/commit/475d6e2f1d72cd8520ab2d2b317ae2ff20777303
Author: Yasuhiro Matsumoto <matt...@gmail.com>
Date: Fri Mar 13 17:36:34 2026 +0000

patch 9.2.0151: blob_from_string() is slow for long strings

Problem: blob_from_string() is slow for long strings
Solution: Use ga_grow() to allocate memory once, perform a bulk copy
with mch_memmove() then translate NL to NUL in-place
(Yasuhiro Matsumoto).

closes: #19665

Signed-off-by: Yasuhiro Matsumoto <matt...@gmail.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/strings.c b/src/strings.c
index fb14e7de6..c5e07590c 100644
--- a/src/strings.c
+++ b/src/strings.c
@@ -1232,13 +1232,20 @@ convert_string(string_T *str, char_u *from, char_u *to, string_T *ret)
static void
blob_from_string(char_u *str, blob_T *blob)
{
- char_u *p;
+ int len = (int)STRLEN(str);
+ char_u *dest;

- for (p = str; *p != NUL; ++p)
- {
- // Translate newlines in the string to NUL character
- ga_append(&blob->bv_ga, (*p == NL) ? NUL : (int)*p);
- }
+ if (len == 0)
+ return;
+ if (ga_grow(&blob->bv_ga, len) == FAIL)
+ return;
+ dest = (char_u *)blob->bv_ga.ga_data + blob->bv_ga.ga_len;
+ mch_memmove(dest, str, (size_t)len);
+ // Translate newlines in the string to NUL characters
+ for (int i = 0; i < len; ++i)
+ if (dest[i] == NL)
+ dest[i] = NUL;
+ blob->bv_ga.ga_len += len;
}

/*
diff --git a/src/version.c b/src/version.c
index 37ef83b97..9969dc786 100644
--- a/src/version.c
+++ b/src/version.c
@@ -734,6 +734,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 151,
/**/
150,
/**/
Reply all
Reply to author
Forward
0 new messages