Commit: patch 9.1.1934: filetype: not all starlark files are recognized

1 view
Skip to first unread message

Christian Brabandt

unread,
Nov 28, 2025, 4:00:38 PM (11 days ago) Nov 28
to vim...@googlegroups.com
patch 9.1.1934: filetype: not all starlark files are recognized

Commit: https://github.com/vim/vim/commit/3ba6a97fea3e62857fe473d8c08415a05b9c316b
Author: Bruno Belanyi <br...@belanyi.fr>
Date: Fri Nov 28 20:48:55 2025 +0000

patch 9.1.1934: filetype: not all starlark files are recognized

Problem: filetype: not all starlark files are recognized
Solution: Detect *.sky files as starlark filetype (Bruno Belanyi)

References:
- https://docs.bazel.build/versions/0.17.1/skylark/spec.html

closes: #18807

Signed-off-by: Bruno Belanyi <br...@belanyi.fr>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/runtime/autoload/dist/ft.vim b/runtime/autoload/dist/ft.vim
index 2ab128a21..f05b6912b 100644
--- a/runtime/autoload/dist/ft.vim
+++ b/runtime/autoload/dist/ft.vim
@@ -3,7 +3,7 @@ vim9script
# Vim functions for file type detection
#
# Maintainer: The Vim Project <https://github.com/vim/vim>
-# Last Change: 2025 Nov 11
+# Last Change: 2025 Nov 28
# Former Maintainer: Bram Moolenaar <Br...@vim.org>

# These functions are moved here from runtime/filetype.vim to make startup
@@ -2705,6 +2705,7 @@ const ft_from_ext = {
"nut": "squirrel",
# Starlark
"ipd": "starlark",
+ "sky": "starlark",
"star": "starlark",
"starlark": "starlark",
# OpenVPN configuration
diff --git a/src/testdir/test_filetype.vim b/src/testdir/test_filetype.vim
index 9bb0ef15c..f98ecb3ed 100644
--- a/src/testdir/test_filetype.vim
+++ b/src/testdir/test_filetype.vim
@@ -769,7 +769,7 @@ def s:GetFilenameChecks(): dict<list<string>>
sshconfig: ['ssh_config', '/.ssh/config', '/etc/ssh/ssh_config.d/file.conf', 'any/etc/ssh/ssh_config.d/file.conf', 'any/.ssh/config', 'any/.ssh/file.conf'],
sshdconfig: ['sshd_config', '/etc/ssh/sshd_config.d/file.conf', 'any/etc/ssh/sshd_config.d/file.conf'],
st: ['file.st'],
- starlark: ['file.ipd', 'file.star', 'file.starlark'],
+ starlark: ['file.ipd', 'file.sky', 'file.star', 'file.starlark'],
stata: ['file.ado', 'file.do', 'file.imata', 'file.mata'],
stp: ['file.stp'],
stylus: ['a.styl', 'file.stylus'],
diff --git a/src/version.c b/src/version.c
index 27e71d493..1d10f93e6 100644
--- a/src/version.c
+++ b/src/version.c
@@ -729,6 +729,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1934,
/**/
1933,
/**/
Reply all
Reply to author
Forward
0 new messages