Commit: patch 9.1.1852: vim9class: memory leak in parse_member()

1 view
Skip to first unread message

Christian Brabandt

unread,
Oct 12, 2025, 11:30:15 AMOct 12
to vim...@googlegroups.com
patch 9.1.1852: vim9class: memory leak in parse_member()

Commit: https://github.com/vim/vim/commit/4b9896ce9de20a83a09ccb37d884a9921d2a2529
Author: Lidong Yan <502024...@smail.nju.edu.cn>
Date: Sun Oct 12 15:10:09 2025 +0000

patch 9.1.1852: vim9class: memory leak in parse_member()

Problem: vim9class: fix memory leak in parse_member()
Solution: Free evalarg before returning (Lidong Yan)

In parse_member(), skip_expr_concatenate() allocates memory in evalarg.
However parse_member() forgets to free evalarg at early return-fail
point. Add clear_evalarg() at early return-fail point.

closes: #18533

Signed-off-by: Lidong Yan <502024...@smail.nju.edu.cn>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/version.c b/src/version.c
index d46906ab2..95f88fcb8 100644
--- a/src/version.c
+++ b/src/version.c
@@ -729,6 +729,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1852,
/**/
1851,
/**/
diff --git a/src/vim9class.c b/src/vim9class.c
index 09d9dffb6..d5c3615dc 100644
--- a/src/vim9class.c
+++ b/src/vim9class.c
@@ -135,6 +135,7 @@ parse_member(
if (*init_arg != NUL && !vim9_comment_start(init_arg))
{
semsg(_(e_trailing_characters_str), init_arg);
+ clear_evalarg(&evalarg, NULL);
return FAIL;
}

Reply all
Reply to author
Forward
0 new messages