Commit: patch 9.1.1653: Coverity complains about Null pointer dereference

3 views
Skip to first unread message

Christian Brabandt

unread,
Aug 20, 2025, 2:45:15 PM8/20/25
to vim...@googlegroups.com
patch 9.1.1653: Coverity complains about Null pointer dereference

Commit: https://github.com/vim/vim/commit/2fd9ac7a69790171ab86c3c3df893959d1fde6ca
Author: Christian Brabandt <c...@256bit.org>
Date: Wed Aug 20 20:31:08 2025 +0200

patch 9.1.1653: Coverity complains about Null pointer dereference

Problem: Coverity complains about Null pointer dereference
(after v9.1.1643)
Solution: Check that TabPageIdx is not Null

Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/mouse.c b/src/mouse.c
index 88d17a545..86400448a 100644
--- a/src/mouse.c
+++ b/src/mouse.c
@@ -347,8 +347,7 @@ do_mouse(
if (!is_drag) // release, reset got_click
{
got_click = FALSE;
- if (in_tab_line || in_tabpanel
- )
+ if (in_tab_line || in_tabpanel)
{
in_tab_line = FALSE;
in_tabpanel = FALSE;
@@ -571,7 +570,7 @@ do_mouse(
}
return TRUE;
}
- else if (is_drag && (in_tabpanel || in_tab_line))
+ else if (is_drag && (in_tabpanel || (in_tab_line && TabPageIdxs != NULL))
{
#if defined(FEAT_TABPANEL)
if (in_tabpanel)
diff --git a/src/version.c b/src/version.c
index 663e3f5ae..359790bfd 100644
--- a/src/version.c
+++ b/src/version.c
@@ -724,6 +724,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1653,
/**/
1652,
/**/
Reply all
Reply to author
Forward
0 new messages