Commit: patch 9.1.1558: str2blob() treats NULL string and empty string differently

0 views
Skip to first unread message

Christian Brabandt

unread,
Jul 17, 2025, 2:15:19 PM7/17/25
to vim...@googlegroups.com
patch 9.1.1558: str2blob() treats NULL string and empty string differently

Commit: https://github.com/vim/vim/commit/2e154d8135abaea76ee1b81240daf46ae091b86b
Author: zeertzjq <zeer...@outlook.com>
Date: Thu Jul 17 20:12:17 2025 +0200

patch 9.1.1558: str2blob() treats NULL string and empty string differently

Problem: str2blob() treats NULL string and empty string differently
Solution: Treats a NULL string the same as an empty string
(zeertzjq).

closes: #17778

Signed-off-by: zeertzjq <zeer...@outlook.com>
Signed-off-by: Yegappan Lakshmanan <yega...@yahoo.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/strings.c b/src/strings.c
index c356c3666..87868b90c 100644
--- a/src/strings.c
+++ b/src/strings.c
@@ -1407,7 +1407,7 @@ f_str2blob(typval_T *argvars, typval_T *rettv)
char_u *str = li->li_tv.vval.v_string;

if (str == NULL)
- continue;
+ str = (char_u *)"";

if (to_encoding != NULL)
{
diff --git a/src/testdir/test_functions.vim b/src/testdir/test_functions.vim
index 4fac4726f..fccd5af49 100644
--- a/src/testdir/test_functions.vim
+++ b/src/testdir/test_functions.vim
@@ -4411,13 +4411,17 @@ func Test_str2blob()
call assert_equal(0z, str2blob([""]))
call assert_equal(0z, str2blob([]))
call assert_equal(0z, str2blob(test_null_list()))
- call assert_equal(0z, str2blob([test_null_string(), test_null_string()]))
+ call assert_equal(0z, str2blob([test_null_string()]))
+ call assert_equal(0z0A, str2blob([test_null_string(), test_null_string()]))
call assert_fails("call str2blob('')", 'E1211: List required for argument 1')
call assert_equal(0z61, str2blob(["a"]))
call assert_equal(0z6162, str2blob(["ab"]))
call assert_equal(0z610062, str2blob(["a
b"]))
call assert_equal(0z61620A6364, str2blob(["ab", "cd"]))
call assert_equal(0z0A, str2blob(["", ""]))
+ call assert_equal(0z610A62, str2blob(["a", "b"]))
+ call assert_equal(0z610A0A62, str2blob(["a", "", "b"]))
+ call assert_equal(0z610A0A62, str2blob(["a", test_null_string(), "b"]))

call assert_equal(0zC2ABC2BB, str2blob(["«»"]))
call assert_equal(0zC59DC59F, str2blob(["ŝş"]))
diff --git a/src/version.c b/src/version.c
index d2710bc1a..638dfc6bb 100644
--- a/src/version.c
+++ b/src/version.c
@@ -719,6 +719,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1558,
/**/
1557,
/**/
Reply all
Reply to author
Forward
0 new messages