Commit: patch 9.1.1354: tests: Test_terminalwinscroll_topline() fails on Windows

2 views
Skip to first unread message

Christian Brabandt

unread,
Apr 29, 2025, 12:30:19 PM4/29/25
to vim...@googlegroups.com
patch 9.1.1354: tests: Test_terminalwinscroll_topline() fails on Windows

Commit: https://github.com/vim/vim/commit/a74d5503d5ba865d5ef17b77d449613fde02cb02
Author: Christian Brabandt <c...@256bit.org>
Date: Tue Apr 29 18:21:31 2025 +0200

patch 9.1.1354: tests: Test_terminalwinscroll_topline() fails on Windows

Problem: tests: Test_terminalwinscroll_topline() fails on Windows
(after v9.1.1348)
Solution: instead of disabling it in Github Actions runners, disable it
for all Windows runs

related: #17196

Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/testdir/test_terminal2.vim b/src/testdir/test_terminal2.vim
index e0f7bc56b..3e8ff86f1 100644
--- a/src/testdir/test_terminal2.vim
+++ b/src/testdir/test_terminal2.vim
@@ -245,9 +245,8 @@ func Test_termwinscroll()
endfunc

func Test_termwinscroll_topline()
- if has('win32')
- CheckGithubActions
- endif
+ " TODO: why does this fail on Appveyor and Github?
+ CheckNotMSWindows

set termwinscroll=1000 mouse=a
terminal
diff --git a/src/version.c b/src/version.c
index 1b28c2dc1..f93213b04 100644
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1354,
/**/
1353,
/**/
Reply all
Reply to author
Forward
0 new messages