Commit: patch 9.1.1310: completion: redundant check for preinsert effect

1 view
Skip to first unread message

Christian Brabandt

unread,
Apr 16, 2025, 1:45:13 PM4/16/25
to vim...@googlegroups.com
patch 9.1.1310: completion: redundant check for preinsert effect

Commit: https://github.com/vim/vim/commit/1c2b25825037bf83862f7af71ce9177cf949daca
Author: glepnir <gleph...@gmail.com>
Date: Wed Apr 16 19:41:19 2025 +0200

patch 9.1.1310: completion: redundant check for preinsert effect

Problem: Duplicate check for preinsert effect, particularly for Ctrl_w
and Ctrl_U.
Solution: Remove the specific check for Ctrl_w and Ctrl_U to eliminate
redundancy (glepnir).

closes: #17129

Signed-off-by: glepnir <gleph...@gmail.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/insexpand.c b/src/insexpand.c
index 55c0e483e..f4449c0bf 100644
--- a/src/insexpand.c
+++ b/src/insexpand.c
@@ -2757,9 +2757,6 @@ ins_compl_stop(int c, int prev_mode, int retval)
retval = TRUE;
}

- if ((c == Ctrl_W || c == Ctrl_U) && ins_compl_preinsert_effect())
- ins_compl_delete();
-
auto_format(FALSE, TRUE);

// Trigger the CompleteDonePre event to give scripts a chance to
diff --git a/src/version.c b/src/version.c
index cf494034f..bdd972311 100644
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1310,
/**/
1309,
/**/
Reply all
Reply to author
Forward
0 new messages