Commit: patch 9.1.0666: assert_equal() doesn't show multibyte string correctly

5 views
Skip to first unread message

Christian Brabandt

unread,
Aug 9, 2024, 2:00:15 PM8/9/24
to vim...@googlegroups.com
patch 9.1.0666: assert_equal() doesn't show multibyte string correctly

Commit: https://github.com/vim/vim/commit/9c4b2462bb498f44044616f7309d111d12170369
Author: zeertzjq <zeer...@outlook.com>
Date: Fri Aug 9 19:52:10 2024 +0200

patch 9.1.0666: assert_equal() doesn't show multibyte string correctly

Problem: assert_equal() doesn't show multibyte string correctly
Solution: Properly advance over a multibyte char.
(zeertzjq)

closes: #15456

Signed-off-by: zeertzjq <zeer...@outlook.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/testdir/test_assert.vim b/src/testdir/test_assert.vim
index d143f19f5..15b18a442 100644
--- a/src/testdir/test_assert.vim
+++ b/src/testdir/test_assert.vim
@@ -48,10 +48,19 @@ func Test_assert_equal()
call assert_match("Expected 'bar' but got 'foo'", v:errors[0])
call remove(v:errors, 0)

+ let s = 'αβγ'
+ call assert_equal(1, assert_equal('δεζ', s))
+ call assert_match("Expected 'δεζ' but got 'αβγ'", v:errors[0])
+ call remove(v:errors, 0)
+
call assert_equal('XxxxxxxxxxxxxxxxxxxxxxX', 'XyyyyyyyyyyyyyyyyyyyyyyyyyX')
call assert_match("Expected 'X\\\[x occurs 21 times]X' but got 'X\\\[y occurs 25 times]X'", v:errors[0])
call remove(v:errors, 0)

+ call assert_equal('ΩωωωωωωωωωωωωωωωωωωωωωΩ', 'ΩψψψψψψψψψψψψψψψψψψψψψψψψψΩ')
+ call assert_match("Expected 'Ω\\\[ω occurs 21 times]Ω' but got 'Ω\\\[ψ occurs 25 times]Ω'", v:errors[0])
+ call remove(v:errors, 0)
+
" special characters are escaped
call assert_equal("

\\x01\x7f", 'x')
call assert_match('Expected ''\b\e\f\n\t\r\\\x01\x7f'' but got ''x''', v:errors[0])
diff --git a/src/testing.c b/src/testing.c
index 18b8e788e..7ab109c10 100644
--- a/src/testing.c
+++ b/src/testing.c
@@ -99,7 +99,7 @@ ga_concat_shorten_esc(garray_T *gap, char_u *str)
return;
}

- for (p = str; *p != NUL; ++p)
+ for (p = str; *p != NUL; )
{
same_len = 1;
s = p;
@@ -118,10 +118,13 @@ ga_concat_shorten_esc(garray_T *gap, char_u *str)
vim_snprintf((char *)buf, NUMBUFLEN, "%d", same_len);
ga_concat(gap, buf);
ga_concat(gap, (char_u *)" times]");
- p = s - 1;
+ p = s;
}
else
+ {
ga_concat_esc(gap, p, clen);
+ p += clen;
+ }
}
}

diff --git a/src/version.c b/src/version.c
index 1b7e42335..1aacff5e6 100644
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 666,
/**/
665,
/**/
Reply all
Reply to author
Forward
0 new messages