Commit: patch 9.1.0405: tests: xxd buffer overflow fails on 32-bit

6 views
Skip to first unread message

Christian Brabandt

unread,
May 10, 2024, 2:15:10 PM5/10/24
to vim...@googlegroups.com
patch 9.1.0405: tests: xxd buffer overflow fails on 32-bit

Commit: https://github.com/vim/vim/commit/b7deb1b69e0841cf7b7f22f57e512f17aa6c5f6c
Author: Christian Brabandt <c...@256bit.org>
Date: Fri May 10 20:00:33 2024 +0200

patch 9.1.0405: tests: xxd buffer overflow fails on 32-bit

Problem: tests: xxd buffer overflow fails on 32-bit
Solution: Skip test on 32-bit architecture

Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/testdir/test_xxd.vim b/src/testdir/test_xxd.vim
index 642f5e709..a91a1fcf9 100644
--- a/src/testdir/test_xxd.vim
+++ b/src/testdir/test_xxd.vim
@@ -412,9 +412,12 @@ func Test_xxd_max_cols()
endfunc


-" Try to trigger a buffer overflow (#14738)
+" This used to trigger a buffer overflow (#14738)
func Test_xxd_buffer_overflow()
CheckUnix
+ if system('file ' .. s:xxd_cmd) =~ '32-bit'
+ throw 'Skipped: test only works on 64-bit architecture'
+ endif
new
let input = repeat('A', 256)
call writefile(['-9223372036854775808: ' . repeat(" [1;32m41 [0m ", 256) . ' ' . repeat(" [1;32mA [0m", 256)], 'Xxdexpected', 'D')
diff --git a/src/version.c b/src/version.c
index 6bb8be6f4..cbd29097d 100644
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 405,
/**/
404,
/**/
Reply all
Reply to author
Forward
0 new messages