Commit: patch 9.1.0106: Visual highlight hard to read with 'termguicolors'

7 views
Skip to first unread message

Christian Brabandt

unread,
Feb 14, 2024, 2:45:11 PM2/14/24
to vim...@googlegroups.com
patch 9.1.0106: Visual highlight hard to read with 'termguicolors'

Commit: https://github.com/vim/vim/commit/34e4a05d02a016fe230495be8f6c60ddd56f9567
Author: Maxim Kim <hab...@gmail.com>
Date: Wed Feb 14 20:28:17 2024 +0100

patch 9.1.0106: Visual highlight hard to read with 'termguicolors'

Problem: Visual highlight hard to read with 'termguicolors'
(Maxim Kim)
Solution: Set Visual GUI foreground to black (with background=light)
and lightgrey (with background=dark)
(Maxim Kim)

fixes: #14024
closes: #14025

Signed-off-by: Maxim Kim <hab...@gmail.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/highlight.c b/src/highlight.c
index 7fbeeb72a..9b3b07244 100644
--- a/src/highlight.c
+++ b/src/highlight.c
@@ -222,7 +222,7 @@ static char *(highlight_init_light[]) = {
"SignColumn term=standout ctermbg=Grey ctermfg=DarkBlue guibg=Grey guifg=DarkBlue"),
#endif
CENT("Visual ctermbg=Grey ctermfg=Black",
- "Visual ctermbg=Grey ctermfg=Black guibg=LightGrey"),
+ "Visual ctermbg=Grey ctermfg=Black guibg=LightGrey guifg=Black"),
#ifdef FEAT_DIFF
CENT("DiffAdd term=bold ctermbg=LightBlue",
"DiffAdd term=bold ctermbg=LightBlue guibg=LightBlue"),
@@ -311,7 +311,7 @@ static char *(highlight_init_dark[]) = {
"SignColumn term=standout ctermbg=DarkGrey ctermfg=Cyan guibg=Grey guifg=Cyan"),
#endif
CENT("Visual ctermbg=Grey ctermfg=Black",
- "Visual ctermbg=Grey ctermfg=Black guibg=#575757"),
+ "Visual ctermbg=Grey ctermfg=Black guibg=#575757 guifg=LightGrey"),
#ifdef FEAT_DIFF
CENT("DiffAdd term=bold ctermbg=DarkBlue",
"DiffAdd term=bold ctermbg=DarkBlue guibg=DarkBlue"),
diff --git a/src/version.c b/src/version.c
index 65b653099..c79fd6b1b 100644
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 106,
/**/
105,
/**/
Reply all
Reply to author
Forward
0 new messages