Commit: patch 9.1.0057: MS-Windows: Key event test still fails

23 views
Skip to first unread message

Christian Brabandt

unread,
Jan 25, 2024, 4:45:07 PM1/25/24
to vim...@googlegroups.com
patch 9.1.0057: MS-Windows: Key event test still fails

Commit: https://github.com/vim/vim/commit/6a02eb073e1c801a5a92837d4b2d44b6a80afddd
Author: Christian Brabandt <c...@256bit.org>
Date: Thu Jan 25 22:28:37 2024 +0100

patch 9.1.0057: MS-Windows: Key event test still fails

Problem: MS-Windows: Key event test still fails
Solution: Skip testing CTRL-C, since it causes an Interrupt
which causes a test failure (after 9.1.0053)

Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/testdir/test_mswin_event.vim b/src/testdir/test_mswin_event.vim
index 950fc61ea..3b7b3c7d5 100644
--- a/src/testdir/test_mswin_event.vim
+++ b/src/testdir/test_mswin_event.vim
@@ -470,19 +470,19 @@ func Test_mswin_event_character_keys()

" Test for <Ctrl-A> to <Ctrl-Z> keys
" Expect the unicode characters 0x01 to 0x1A
-" Note: May cause an Interrupt to be triggered for Ctrl-C
+" Note: Skip C because it triggers an Interrupt (CTRL-C)
+" which causes a test failure
for modkey in [s:VK.CONTROL, s:VK.LCONTROL, s:VK.RCONTROL]
for kc in range(65, 90)
- try
- call SendKeyGroup([modkey, kc])
- let ch = Getcharstr()
- call assert_equal(nr2char(kc - 64), ch)
- call SendKeyWithModifiers(kc, s:MOD_MASK_CTRL)
- let ch = Getcharstr()
- call assert_equal(nr2char(kc - 64), ch)
- catch /^Vim:Interrupt$/
- " ignore
- endtry
+ if kc == 67
+ continue
+ endif
+ call SendKeyGroup([modkey, kc])
+ let ch = Getcharstr()
+ call assert_equal(nr2char(kc - 64), ch)
+ call SendKeyWithModifiers(kc, s:MOD_MASK_CTRL)
+ let ch = Getcharstr()
+ call assert_equal(nr2char(kc - 64), ch)
endfor
endfor

diff --git a/src/version.c b/src/version.c
index d06e7e99a..8f13f3f18 100644
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 57,
/**/
56,
/**/
Reply all
Reply to author
Forward
0 new messages