[vim/vim] bindzone runtime: add new DNS record types (#7351)

16 views
Skip to first unread message

Stuart Henderson

unread,
Nov 23, 2020, 5:46:54 AM11/23/20
to vim/vim, Subscribed

Recognize some newer DNS record types - CAA (RFC8659, certificate authority authorization), OPENPGPKEY (RFC7929), SMIMEA (RFC8162). Sort SSHFP alphabetically while there.

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/7351

Commit Summary

  • bindzone runtime: add new DNS record types

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

codecov[bot]

unread,
Nov 23, 2020, 10:15:56 AM11/23/20
to vim/vim, Subscribed

Codecov Report

Merging #7351 (6b6812a) into master (792f786) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@

##           master    #7351      +/-   ##

==========================================

- Coverage   88.88%   88.87%   -0.01%     

==========================================

  Files         148      148              

  Lines      162999   162999              

==========================================

- Hits       144879   144863      -16     

- Misses      18120    18136      +16
Impacted Files Coverage Δ
src/diff.c 85.03% <0.00%> (-0.95%) ⬇️
src/mbyte.c 79.89% <0.00%> (-0.38%) ⬇️
src/ex_getln.c 91.37% <0.00%> (-0.35%) ⬇️
src/getchar.c 86.13% <0.00%> (-0.29%) ⬇️
src/move.c 94.12% <0.00%> (-0.26%) ⬇️
src/xdiff/xdiffi.c 67.93% <0.00%> (-0.24%) ⬇️
src/drawscreen.c 85.03% <0.00%> (-0.16%) ⬇️
src/message.c 88.81% <0.00%> (-0.05%) ⬇️
src/if_xcmdsrv.c 88.55% <0.00%> (ø)
src/channel.c 90.08% <0.00%> (+0.05%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 792f786...6b6812a. Read the comment docs.

Bram Moolenaar

unread,
Nov 23, 2020, 12:10:03 PM11/23/20
to vim/vim, Subscribed

Have you tried contacting the maintainer, as mentioned in the header?

Stuart Henderson

unread,
Nov 23, 2020, 1:25:16 PM11/23/20
to vim/vim, Subscribed

Hmm, I thought it was no longer valid because www.mehnle.net came back 'domain not found' and the last updated date on the file was 2011 and there had been several commits to the file in vim since then, but now I see that mehnle.net itself does still exist so I'll try emailing.

Stuart Henderson

unread,
Nov 28, 2020, 10:24:23 AM11/28/20
to vim/vim, Subscribed

No response to my email yet. In the meantime I have found another updated bindzone.vim on github which maybe a better source (it has a few other changes): https://github.com/sebastianw/vim-bindzone/

Michel Le Bihan

unread,
Apr 14, 2021, 9:37:26 AM4/14/21
to vim/vim, Subscribed

Hello,
Their website is indeed down, but their mail server is responding:

michel@debian:~$ dig +short MX mehnle.net
10 callisto.mehnle.net.
michel@debian:~$ nc callisto.mehnle.net 25
220 callisto.mehnle.net ESMTP Postfix (Ubuntu)
QUIT 
221 2.0.0 Bye

Michel Le Bihan

unread,
Apr 14, 2021, 10:07:40 AM4/14/21
to vim/vim, Subscribed

Actually, isn't it @jmehnle ?

Christian Brabandt

unread,
Aug 17, 2023, 6:04:55 PM8/17/23
to vim/vim, Subscribed

let me merge it

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/7351/c1683037752@github.com>

Christian Brabandt

unread,
Aug 17, 2023, 6:05:04 PM8/17/23
to vim/vim, Subscribed

Merged #7351 into master.

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/7351/issue_event/10124291688@github.com>

Christian Brabandt

unread,
Aug 17, 2023, 6:15:12 PM8/17/23
to vim...@googlegroups.com
bindzone runtime: add new DNS record types (#7351)

Commit: https://github.com/vim/vim/commit/442d1746f4c650e2e41246fd5679f635a4a30232
Author: Stuart Henderson <st...@users.noreply.github.com>
Date: Thu Aug 17 23:04:24 2023 +0100

bindzone runtime: add new DNS record types (https://github.com/vim/vim/issues/7351)

Recognize some newer DNS record types - CAA (RFC8659, certificate authority authorization), OPENPGPKEY (RFC7929), SMIMEA (RFC8162). Sort SSHFP alphabetically while there.

diff --git a/runtime/syntax/bindzone.vim b/runtime/syntax/bindzone.vim
index bb790bb75..fede3d97d 100644
--- a/runtime/syntax/bindzone.vim
+++ b/runtime/syntax/bindzone.vim
@@ -33,7 +33,7 @@ syn match zoneDomain contained /[^[:space:]!"#$%&'()*+,\/:;<=>?@[\]\
syn match zoneSpecial contained /^[@*.]\s/
syn match zoneTTL contained /\s\@<=\d[0-9WwDdHhMmSs]*\(\s\|$\)\@=/ nextgroup=zoneClass,zoneRRType skipwhite
syn keyword zoneClass contained IN CHAOS CH HS HESIOD nextgroup=zoneRRType,zoneTTL skipwhite
-syn keyword zoneRRType contained A AAAA CERT CNAME DNAME DNSKEY DS HINFO LOC MX NAPTR NS NSEC NSEC3 NSEC3PARAM PTR RP RRSIG SSHFP SOA SPF SRV TLSA TXT nextgroup=zoneRData skipwhite
+syn keyword zoneRRType contained A AAAA CAA CERT CNAME DNAME DNSKEY DS HINFO LOC MX NAPTR NS NSEC NSEC3 NSEC3PARAM OPENPGPKEY PTR RP RRSIG SMIMEA SOA SPF SRV SSHFP TLSA TXT nextgroup=zoneRData skipwhite
syn match zoneRData contained /[^;]*/ contains=zoneDomain,zoneIPAddr,zoneIP6Addr,zoneText,zoneNumber,zoneParen,zoneUnknown

syn match zoneIPAddr contained /\<[0-9]\{1,3}\(\.[0-9]\{1,3}\)\{,3}\>/
Reply all
Reply to author
Forward
0 new messages