[vim/vim] Add a macro to iterate over all the grow array items (PR #12120)
Yegappan Lakshmanan
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/12120
Commit Summary
- 8f1240a Add a macro to iterate over all the grow array items
File Changes
(43 files)
- M src/alloc.c (8)
- M src/autocmd.c (9)
- M src/blob.c (4)
- M src/channel.c (4)
- M src/debugger.c (10)
- M src/digraph.c (10)
- M src/evalfunc.c (2)
- M src/evalvars.c (2)
- M src/ex_cmds2.c (2)
- M src/fileio.c (2)
- M src/filepath.c (6)
- M src/findfile.c (6)
- M src/fold.c (24)
- M src/help.c (4)
- M src/highlight.c (14)
- M src/if_lua.c (2)
- M src/if_xcmdsrv.c (2)
- M src/json.c (4)
- M src/list.c (2)
- M src/macros.h (3)
- M src/menu.c (6)
- M src/message.c (2)
- M src/misc1.c (4)
- M src/os_amiga.c (2)
- M src/profiler.c (4)
- M src/regexp_bt.c (2)
- M src/scriptfile.c (9)
- M src/session.c (2)
- M src/spell.c (22)
- M src/spellfile.c (16)
- M src/spellsuggest.c (32)
- M src/syntax.c (12)
- M src/tag.c (4)
- M src/terminal.c (6)
- M src/usercmd.c (12)
- M src/userfunc.c (12)
- M src/vim9class.c (34)
- M src/vim9compile.c (10)
- M src/vim9execute.c (14)
- M src/vim9instr.c (2)
- M src/vim9script.c (8)
- M src/vim9type.c (3)
- M src/viminfo.c (6)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
@yegappan pushed 1 commit.
- eb6dadc Fix build warning
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
codecov[bot]
Codecov Report
Merging #12120 (b1eafc4) into master (7ac5023) will decrease coverage by
0.82%.
The diff coverage is97.02%.
@@ Coverage Diff @@ ## master #12120 +/- ## ========================================== - Coverage 81.93% 81.11% -0.82% ========================================== Files 164 154 -10 Lines 194067 183608 -10459 Branches 43829 41239 -2590 ========================================== - Hits 159009 148939 -10070 + Misses 22225 21723 -502 - Partials 12833 12946 +113
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | 82.65% <97.02%> (+<0.01%) |
⬆️ |
| huge-gcc-none | ? |
|
| huge-gcc-testgui | ? |
|
| huge-gcc-unittests | 0.29% <0.00%> (ø) |
|
| linux | 81.11% <97.02%> (-1.25%) |
⬇️ |
| mingw-x64-HUGE | ? |
|
| mingw-x86-HUGE | ? |
|
| windows | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/ex_cmds2.c | 78.98% <0.00%> (-2.18%) |
⬇️ |
| src/vim9type.c | 87.00% <50.00%> (-3.06%) |
⬇️ |
| src/syntax.c | 79.61% <83.33%> (-0.77%) |
⬇️ |
| src/highlight.c | 78.83% <85.71%> (-2.69%) |
⬇️ |
| src/vim9class.c | 80.35% <93.75%> (-1.43%) |
⬇️ |
| src/alloc.c | 78.21% <100.00%> (ø) |
|
| src/autocmd.c | 86.08% <100.00%> (-1.43%) |
⬇️ |
| src/blob.c | 89.87% <100.00%> (-2.08%) |
⬇️ |
| src/channel.c | 82.50% <100.00%> (-0.60%) |
⬇️ |
| src/debugger.c | 88.70% <100.00%> (-3.43%) |
⬇️ |
| ... and 177 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
Yegappan wrote:
> * Add a macro to iterate over all the grow array items
Hmm, I'm not sure this is really an improvement. There isn't any
complexity that the macro takes care of, and it shortens the code only a
little bit. A disadvantage is that it obscures what the for loop really
does. And inlining the declaration of the loop variable would require
another macro.
What do others think?
--
hundred-and-one symptoms of being an internet addict:
250. You've given up the search for the "perfect woman" and instead,
sit in front of the PC until you're just too tired to care.
/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
Yegappan wrote:
> * Add a macro to iterate over all the grow array items
Hmm, I'm not sure this is really an improvement. There isn't any
complexity that the macro takes care of, and it shortens the code only a
little bit. A disadvantage is that it obscures what the for loop really
does. And inlining the declaration of the loop variable would require
another macro.
What do others think?
vim-dev ML
On Wed, Mar 8, 2023 at 1:59 PM Bram Moolenaar ***@***.***>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@yegappan do you still think this is good to include?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you commented.
Christian Brabandt
Closed #12120.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you commented.
Christian Brabandt
closing because seems to have been staled
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.