[vim/vim] Add some more tests for ops.c (#8290)

12 views
Skip to first unread message

Yegappan Lakshmanan

unread,
May 30, 2021, 3:29:32 PM5/30/21
to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/8290

Commit Summary

  • Add some more tests for ops.c

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Bram Moolenaar

unread,
May 30, 2021, 3:45:56 PM5/30/21
to vim/vim, Subscribed

Looks like this triggers an ASAN error. Can you fix that?

Yegappan Lakshmanan

unread,
May 30, 2021, 3:57:41 PM5/30/21
to vim/vim, Push

@yegappan pushed 1 commit.

  • 3c0e5aa Comment out the increment/decrement number test

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Yegappan Lakshmanan

unread,
May 30, 2021, 3:59:25 PM5/30/21
to vim_dev, reply+ACY5DGEGRRGANBJPJJ...@reply.github.com, vim/vim, Subscribed
Hi Bram,

On Sun, May 30, 2021 at 12:45 PM Bram Moolenaar <vim-dev...@256bit.org> wrote:

Looks like this triggers an ASAN error. Can you fix that?



I am taking a look at the ASAN error. The netbeans_inserted() call in
op_addsub() is referring to a character which is already removed.
I will see how to address this. For now, I have commented out this test.

- Yegappan

vim-dev ML

unread,
May 30, 2021, 3:59:41 PM5/30/21
to vim/vim, vim-dev ML, Your activity

Hi Bram,

On Sun, May 30, 2021 at 12:45 PM Bram Moolenaar ***@***.***>

wrote:

> Looks like this triggers an ASAN error. Can you fix that?
>
>
>
I am taking a look at the ASAN error. The netbeans_inserted() call in
op_addsub() is referring to a character which is already removed.
I will see how to address this. For now, I have commented out this test.

- Yegappan

codecov[bot]

unread,
May 30, 2021, 4:04:27 PM5/30/21
to vim/vim, vim-dev ML, Comment

Codecov Report

Merging #8290 (3c0e5aa) into master (d2ea7cf) will decrease coverage by 87.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@

##           master    #8290       +/-   ##

===========================================

- Coverage   89.59%    2.50%   -87.10%     

===========================================

  Files         148      146        -2     

  Lines      167042   161895     -5147     

===========================================

- Hits       149660     4050   -145610     

- Misses      17382   157845   +140463
Flag Coverage Δ
huge-clang-none ?
huge-gcc-none ?
huge-gcc-testgui ?
huge-gcc-unittests 2.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sha256.c 0.00% <0.00%> (-97.96%) ⬇️
src/digraph.c 0.00% <0.00%> (-97.78%) ⬇️
src/gui_gtk_f.c 0.00% <0.00%> (-97.54%) ⬇️
src/match.c 0.00% <0.00%> (-97.13%) ⬇️
src/crypt_zip.c 0.00% <0.00%> (-97.06%) ⬇️
src/evalbuffer.c 0.00% <0.00%> (-96.83%) ⬇️
src/debugger.c 0.00% <0.00%> (-96.62%) ⬇️
src/libvterm/src/rect.h 0.00% <0.00%> (-96.56%) ⬇️
src/evalfunc.c 0.00% <0.00%> (-96.51%) ⬇️
src/textprop.c 0.00% <0.00%> (-96.45%) ⬇️
... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ea7cf...3c0e5aa. Read the comment docs.

—
You are receiving this because you commented.

Yegappan Lakshmanan

unread,
May 30, 2021, 11:54:29 PM5/30/21
to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

  • 17a9993 Get the buffer line just before using it

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
May 31, 2021, 12:08:33 AM5/31/21
to vim/vim, vim-dev ML, Push

@yegappan pushed 3 commits.

  • f195049 Add some more tests for ops.c
  • 8fce76a Comment out the increment/decrement number test
  • b7879c3 Get the buffer line just before using it

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
May 31, 2021, 12:15:18 PM5/31/21
to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

  • 6f15dc3 Add a test for specifying a count after an operator

—
You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,
May 31, 2021, 1:23:28 PM5/31/21
to vim/vim, vim-dev ML, Comment

Closed #8290 via 2ac7184.

—
You are receiving this because you commented.

Reply all
Reply to author
Forward
0 new messages