[vim/vim] Remove unused code (PR #10136)

10 views
Skip to first unread message

Dominique Pellé

unread,
Apr 9, 2022, 6:15:09 PM4/9/22
to vim/vim, Subscribed

This PR removes or disables some unused code.

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/10136

Commit Summary

File Changes

(4 files)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10136@github.com>

Dominique Pellé

unread,
Apr 9, 2022, 6:29:49 PM4/9/22
to vim/vim, Push

@dpelle pushed 1 commit.

  • bcc9280 Remove doc tags of removed errors

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10136/push/9584000761@github.com>

codecov[bot]

unread,
Apr 9, 2022, 6:37:17 PM4/9/22
to vim/vim, Subscribed

Codecov Report

Merging #10136 (bcc9280) into master (5e17922) will increase coverage by 1.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@

##           master   #10136      +/-   ##

==========================================

+ Coverage   81.98%   83.25%   +1.27%     

==========================================

  Files         167      153      -14     

  Lines      187824   175408   -12416     

  Branches    42355    39707    -2648     

==========================================

- Hits       153983   146043    -7940     

+ Misses      21494    17198    -4296     

+ Partials    12347    12167     -180
Flag Coverage Δ
huge-clang-none 82.39% <ø> (+<0.01%) ⬆️
huge-gcc-none ?
huge-gcc-testgui 81.19% <ø> (+<0.01%) ⬆️
huge-gcc-unittests 2.00% <ø> (-0.01%) ⬇️
linux 83.25% <ø> (-0.72%) ⬇️
mingw-x64-HUGE ?
mingw-x64-HUGE-gui ?
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/option.c 88.17% <ø> (+0.18%) ⬆️
src/search.c 85.10% <ø> (-0.40%) ⬇️
src/libvterm/src/rect.h 0.00% <0.00%> (-96.78%) ⬇️
src/libvterm/src/state.c 38.86% <0.00%> (-50.77%) ⬇️
src/libvterm/include/vterm.h 0.00% <0.00%> (-44.45%) ⬇️
src/libvterm/src/keyboard.c 47.36% <0.00%> (-40.27%) ⬇️
src/libvterm/src/pen.c 48.81% <0.00%> (-35.46%) ⬇️
src/libvterm/src/parser.c 60.83% <0.00%> (-35.07%) ⬇️
src/libvterm/src/encoding.c 39.39% <0.00%> (-34.14%) ⬇️
src/libvterm/src/vterm.c 39.17% <0.00%> (-27.21%) ⬇️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e17922...bcc9280. Read the comment docs.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10136/c1094135350@github.com>

Dominique Pellé

unread,
Apr 10, 2022, 2:47:45 AM4/10/22
to vim/vim, Subscribed

@dpelle commented on this pull request.

In src/search.c:

> @@ -5050,16 +5050,3 @@ fuzzymatches_to_strmatches(
 
     return OK;
 }
-
-/*
- * Free a list of fuzzy string matches.
- */
-    void
-fuzmatch_str_free(fuzmatch_str_T *fuzmatch, int count)
-{
-    if (count <= 0 || fuzmatch == NULL)
-	return;
-    while (count--)
-	vim_free(fuzmatch[count].str);
-    vim_free(fuzmatch);
-}

To @yegappan : was this meant to be used?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10136/review/937213704@github.com>

Bram Moolenaar

unread,
Apr 10, 2022, 6:27:45 AM4/10/22
to vim/vim, Subscribed

Closed #10136 via 7765f5c.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10136/issue_event/6403600754@github.com>

Yegappan Lakshmanan

unread,
Apr 10, 2022, 10:20:42 AM4/10/22
to vim_dev, reply+ACY5DGEK6SAPXE24LR...@reply.github.com, vim/vim, Subscribed
Hi,

On Sat, Apr 9, 2022 at 11:47 PM Dominique Pellé <vim-dev...@256bit.org> wrote:

@dpelle commented on this pull request.

In src/search.c:

> @@ -5050,16 +5050,3 @@ fuzzymatches_to_strmatches(
 
     return OK;
 }
-
-/*
- * Free a list of fuzzy string matches.
- */
-    void
-fuzmatch_str_free(fuzmatch_str_T *fuzmatch, int count)
-{
-    if (count <= 0 || fuzmatch == NULL)
-	return;
-    while (count--)
-	vim_free(fuzmatch[count].str);
-    vim_free(fuzmatch);
-}

To @yegappan : was this meant to be used?


Yes. This function can be used in a couple of places:
cmdexpand.c:2881 and search.c:5035.

Regards,
Yegappan

vim-dev ML

unread,
Apr 10, 2022, 10:21:02 AM4/10/22
to vim/vim, vim-dev ML, Your activity

Hi,

On Sat, Apr 9, 2022 at 11:47 PM Dominique Pellé ***@***.***>
wrote:

> ***@***.**** commented on this pull request.
> ------------------------------
>
> In src/search.c
> <https://github.com/vim/vim/pull/10136#discussion_r846724153>:

>
> > @@ -5050,16 +5050,3 @@ fuzzymatches_to_strmatches(
>
> return OK;
> }
> -
> -/*
> - * Free a list of fuzzy string matches.
> - */
> - void
> -fuzmatch_str_free(fuzmatch_str_T *fuzmatch, int count)
> -{
> - if (count <= 0 || fuzmatch == NULL)
> - return;
> - while (count--)
> - vim_free(fuzmatch[count].str);
> - vim_free(fuzmatch);
> -}
>
> To @yegappan <https://github.com/yegappan> : was this meant to be used?

>
>
> Yes. This function can be used in a couple of places:
cmdexpand.c:2881 and search.c:5035.

Regards,
Yegappan

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10136/c1094285287@github.com>

Reply all
Reply to author
Forward
0 new messages