[vim/vim] Vim9: Add argument type checks for more functions (#8587)

6 views
Skip to first unread message

Yegappan Lakshmanan

unread,
Jul 18, 2021, 4:18:43 PM7/18/21
to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/8587

Commit Summary

  • Vim9: Add argument type checks for more functions

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yegappan Lakshmanan

unread,
Jul 18, 2021, 4:46:39 PM7/18/21
to vim/vim, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Yegappan Lakshmanan

unread,
Jul 18, 2021, 4:49:49 PM7/18/21
to vim/vim, Push

@yegappan pushed 2 commits.

  • f3b00a6 Vim9: Add argument type checks for more functions
  • 6ba440f Fix test failure

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
Jul 18, 2021, 4:53:00 PM7/18/21
to vim/vim, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
Jul 18, 2021, 5:03:21 PM7/18/21
to vim/vim, Push

@yegappan pushed 1 commit.

  • ef8330e Fix for overlapping error numbers

—
You are receiving this because you are subscribed to this thread.

codecov[bot]

unread,
Jul 18, 2021, 5:13:34 PM7/18/21
to vim/vim, Subscribed

Codecov Report

Merging #8587 (ef8330e) into master (885971e) will decrease coverage by 87.55%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@

##           master    #8587       +/-   ##

===========================================

- Coverage   90.04%    2.48%   -87.56%     

===========================================

  Files         150      148        -2     

  Lines      168490   163422     -5068     

===========================================

- Hits       151720     4068   -147652     

- Misses      16770   159354   +142584
Flag Coverage Δ
huge-clang-none ?
huge-gcc-none ?
huge-gcc-testgui ?
huge-gcc-unittests 2.48% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/blob.c 0.00% <0.00%> (-92.96%) ⬇️
src/channel.c 0.10% <0.00%> (-89.93%) ⬇️
src/clientserver.c 0.00% <0.00%> (-87.97%) ⬇️
src/cmdhist.c 0.00% <0.00%> (-96.68%) ⬇️
src/dict.c 5.50% <0.00%> (-86.42%) ⬇️
src/diff.c 0.00% <0.00%> (-90.24%) ⬇️
src/eval.c 0.10% <0.00%> (-96.00%) ⬇️
src/evalbuffer.c 0.00% <0.00%> (-96.83%) ⬇️
src/evalfunc.c 0.00% <0.00%> (-96.29%) ⬇️
src/evalvars.c 5.16% <0.00%> (-91.13%) ⬇️
... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 885971e...ef8330e. Read the comment docs.

Yegappan Lakshmanan

unread,
Jul 18, 2021, 11:24:53 PM7/18/21
to vim/vim, Push

@yegappan pushed 1 commit.

  • afe3a66 Add argument type check for more functions

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
Jul 19, 2021, 1:20:02 AM7/19/21
to vim/vim, Push

@yegappan pushed 1 commit.

  • f7c16e8 Add argument type check for more functions

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
Jul 19, 2021, 9:41:56 AM7/19/21
to vim/vim, Push

@yegappan pushed 1 commit.

  • 7034f35 Vim9: Add argument type checks for more functions

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
Jul 19, 2021, 11:40:54 AM7/19/21
to vim/vim, Push

@yegappan pushed 1 commit.

  • 6884a52 Add additional argument type checks

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
Jul 19, 2021, 11:45:05 AM7/19/21
to vim/vim, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
Jul 19, 2021, 12:57:23 PM7/19/21
to vim/vim, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,
Jul 19, 2021, 3:11:08 PM7/19/21
to vim/vim, Subscribed

strange that Test_vim9_maparg() only fails with asan.

Yegappan Lakshmanan

unread,
Jul 19, 2021, 4:25:39 PM7/19/21
to vim/vim, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
Jul 19, 2021, 4:25:53 PM7/19/21
to vim_dev, reply+ACY5DGCLPJWW5JJME4...@reply.github.com, vim/vim, Subscribed
Hi Bram,

On Mon, Jul 19, 2021 at 12:11 PM Bram Moolenaar <vim-dev...@256bit.org> wrote:

strange that Test_vim9_maparg() only fails with asan.



I have updated the PR with a fix for this.

Regards,
Yegappan 

vim-dev ML

unread,
Jul 19, 2021, 4:26:08 PM7/19/21
to vim/vim, vim-dev ML, Your activity

Hi Bram,

On Mon, Jul 19, 2021 at 12:11 PM Bram Moolenaar ***@***.***>

wrote:

> strange that Test_vim9_maparg() only fails with asan.
>
>
>
I have updated the PR with a fix for this.

Regards,
Yegappan

Yegappan Lakshmanan

unread,
Jul 19, 2021, 4:37:31 PM7/19/21
to vim/vim, vim-dev ML, Push

@yegappan pushed 2 commits.

  • f4ed460 Vim9: Add argument type checks for more functions
  • 0e895a3 Update error numbers

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
Jul 20, 2021, 10:47:19 AM7/20/21
to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

  • 29fef4e Vim9: Add argument type checks for more functions

—
You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,
Jul 20, 2021, 11:52:15 AM7/20/21
to vim/vim, vim-dev ML, Comment

Closed #8587 via 83494b4.

—
You are receiving this because you commented.

Reply all
Reply to author
Forward
0 new messages