Yegappan Lakshmanan

unread,

Aug 26, 2022, 10:45:20 PM8/26/22

to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/10991

Commit Summary

217d157 Modify getscriptinfo() to return script-local functions and variables when querying for a specific script

File Changes

(5 files)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Aug 27, 2022, 12:53:25 AM8/27/22

to vim/vim, Push

@yegappan pushed 1 commit.

be5e92e Fix test failure in MS-Windows

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

codecov[bot]

unread,

Aug 27, 2022, 1:04:52 AM8/27/22

to vim/vim, Subscribed

Codecov Report

Merging #10991 (be5e92e) into master (5ff595d) will increase coverage by 0.03%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@

##           master   #10991      +/-   ##

==========================================

+ Coverage   82.40%   82.44%   +0.03%     

==========================================

  Files         152      152              

  Lines      177500   177526      +26     

  Branches    40279    40287       +8     

==========================================

+ Hits       146272   146357      +85     

+ Misses      19043    18983      -60     

- Partials    12185    12186       +1

Flag	Coverage Δ
huge-clang-none	`82.71% <85.71%> (+<0.01%)`	⬆️
huge-gcc-none	`?`
huge-gcc-testgui	`54.01% <85.18%> (?)`
huge-gcc-unittests	`0.30% <0.00%> (-0.01%)`	⬇️
linux	`82.44% <85.71%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/userfunc.c	`89.30% <ø> (ø)`
src/scriptfile.c	`83.67% <85.71%> (+0.38%)`	⬆️
src/main.c	`81.18% <0.00%> (-3.53%)`	⬇️
src/clipboard.c	`71.78% <0.00%> (-1.68%)`	⬇️
src/popupmenu.c	`78.87% <0.00%> (-0.81%)`	⬇️
src/beval.c	`63.30% <0.00%> (-0.72%)`	⬇️
src/if_xcmdsrv.c	`76.88% <0.00%> (-0.71%)`	⬇️
src/ex_cmds2.c	`81.21% <0.00%> (-0.49%)`	⬇️
src/mouse.c	`78.74% <0.00%> (-0.32%)`	⬇️
src/message.c	`80.10% <0.00%> (-0.18%)`	⬇️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Aug 27, 2022, 5:50:24 AM8/27/22

to vim/vim, Subscribed

> * Modify getscriptinfo() to return script-local functions and

> variables when querying for a specific script

How about adding "sid" to the {opts} argument, so that it's easy to
select one specific script. Selecting by name would require using the
whole file name. That might even have forward/backward slash issues.

Then, if we can use "sid", how about only returning functions and
variables when "sid" is used? Since then we have only one script, while
with "name" it may still be a few (e.g. when finding autoload scripts
you would get functions and variables even though you don't need them).

For dict_copy() get_copyID() should be used.

--
"Software is like sex... it's better when it's free."
-- Linus Torvalds, initiator of the free Linux OS
Makes me wonder what FSF stands for...?

/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Aug 27, 2022, 10:10:13 AM8/27/22

to vim/vim, Push

@yegappan pushed 1 commit.

018e2fa getscriptinfo(): Support for selecting a script using script ID

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Aug 27, 2022, 10:12:38 AM8/27/22

to vim_dev, reply+ACY5DGCY3HYTMQ2GXC...@reply.github.com, vim/vim, Subscribed

Hi Bram,

On Sat, Aug 27, 2022 at 2:50 AM Bram Moolenaar <vim-dev...@256bit.org> wrote:

> * Modify getscriptinfo() to return script-local functions and
> variables when querying for a specific script

How about adding "sid" to the {opts} argument, so that it's easy to
select one specific script. Selecting by name would require using the
whole file name. That might even have forward/backward slash issues.

Then, if we can use "sid", how about only returning functions and
variables when "sid" is used? Since then we have only one script, while
with "name" it may still be a few (e.g. when finding autoload scripts
you would get functions and variables even though you don't need them).

For dict_copy() get_copyID() should be used.

I have updated the PR to incorporate these comments.

Regards,

Yegappan

vim-dev ML

unread,

Aug 27, 2022, 10:12:55 AM8/27/22

to vim/vim, vim-dev ML, Your activity

Hi Bram,

On Sat, Aug 27, 2022 at 2:50 AM Bram Moolenaar ***@***.***>
wrote:

>
> > * Modify getscriptinfo() to return script-local functions and

> > variables when querying for a specific script
>

> How about adding "sid" to the {opts} argument, so that it's easy to
> select one specific script. Selecting by name would require using the
> whole file name. That might even have forward/backward slash issues.
>
> Then, if we can use "sid", how about only returning functions and
> variables when "sid" is used? Since then we have only one script, while
> with "name" it may still be a few (e.g. when finding autoload scripts
> you would get functions and variables even though you don't need them).
>
> For dict_copy() get_copyID() should be used.
>
>
I have updated the PR to incorporate these comments.

Regards,
Yegappan

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Aug 27, 2022, 5:42:28 PM8/27/22

to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

f6fdcba Modify getscriptinfo() to return script-local functions and variables when querying for a specific script

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Aug 28, 2022, 11:21:16 AM8/28/22

to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

170f191 Modify getscriptinfo() to return script-local functions and variables when querying for a specific script

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Aug 28, 2022, 1:52:34 PM8/28/22

to vim/vim, vim-dev ML, Comment

Closed #10991 via 2f892d8.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you commented.

Reply all

Reply to author

Forward

[vim/vim] Modify getscriptinfo() to return script-local functions and variables when querying for a specific script (PR #10991)

Yegappan Lakshmanan

You can view, comment on, or merge this pull request online at:

Commit Summary

File Changes

Patch Links:

Yegappan Lakshmanan

codecov[bot]

Codecov Report

Bram Moolenaar

Yegappan Lakshmanan

Yegappan Lakshmanan

vim-dev ML

Yegappan Lakshmanan

Yegappan Lakshmanan

Bram Moolenaar