Patch 8.2.1735

12 views
Skip to first unread message

Bram Moolenaar

unread,
Sep 23, 2020, 4:27:57 PM9/23/20
to vim...@googlegroups.com

Patch 8.2.1735
Problem: Github actions appear to timeout too soon.
Solution: use "timeout" instead of "ping".
Files: .github/workflows/ci-windows.yaml


*** ../vim-8.2.1734/.github/workflows/ci-windows.yaml 2020-08-31 21:30:28.994020232 +0200
--- .github/workflows/ci-windows.yaml 2020-09-23 22:25:25.166148685 +0200
***************
*** 212,220 ****
echo %COL_GREEN%Wait for vim tests to finish.%COL_RESET%
cd ..\src2\testdir
:: Wait about 10 minutes.
! for /L %%i in (1,1,600) do (
if exist done.txt goto exitloop
! ping -n 2 localhost > nul
)
set timeout=1
:exitloop
--- 212,220 ----
echo %COL_GREEN%Wait for vim tests to finish.%COL_RESET%
cd ..\src2\testdir
:: Wait about 10 minutes.
! for /L %%i in (1,1,60) do (
if exist done.txt goto exitloop
! timeout 10
)
set timeout=1
:exitloop
*** ../vim-8.2.1734/src/version.c 2020-09-23 21:57:16.641934712 +0200
--- src/version.c 2020-09-23 22:26:55.369871932 +0200
***************
*** 752,753 ****
--- 752,755 ----
{ /* Add new patch number below this line */
+ /**/
+ 1735,
/**/

--
Managers are like cats in a litter box. They instinctively shuffle things
around to conceal what they've done.
(Scott Adams - The Dilbert principle)

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Bram Moolenaar

unread,
Sep 23, 2020, 5:06:28 PM9/23/20
to vim...@googlegroups.com, ktakat...@gmail.com, Bram Moolenaar
Looks like this didn't make a difference. So why is it "cancelled by
user" after less than three minutes? Most of the action runs fail,
which means I tend to ignore them and they are hardly useful.


--
An easy way to determine if you have enough teamwork to be doomed is simply to
measure how long it takes from the time you decide to go to lunch together
until the time you actually eat.

Yegappan Lakshmanan

unread,
Sep 23, 2020, 7:56:54 PM9/23/20
to vim_dev, ktakat...@gmail.com, Bram Moolenaar
Hi Bram,

On Wed, Sep 23, 2020 at 2:06 PM Bram Moolenaar <Br...@moolenaar.net> wrote:


Looks like this didn't make a difference.  So why is it "cancelled by
user" after less than three minutes?  Most of the action runs fail,
which means I tend to ignore them and they are hardly useful.



I agree. Most of the time the Github action tests are failing.
So they are not useful. How do we address the test failures?
We didn't have these many frequent test failures with the Appveyor
Windows builds/tests.

Regards,
Yegappan
 
Reply all
Reply to author
Forward
0 new messages