[vim/vim] Using a null partial in filter() crashes Vim (#5976)

[Yegappan Lakshmanan]

Fix the crash when using a null partial function in filter().
When comparing two null partials return True.
Add additional test for eval functionality.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/5976

Commit Summary

• Using a null partial in filter() crashes Vim. Comparing two null partial returns False.

File Changes

• M src/eval.c (8)
• M src/testdir/test_blob.vim (1)
• M src/testdir/test_channel.vim (3)
• M src/testdir/test_eval_stuff.vim (2)
• M src/testdir/test_execute_func.vim (4)
• M src/testdir/test_expr.vim (12)
• M src/testdir/test_filter_map.vim (4)
• M src/testdir/test_fold.vim (25)
• M src/testdir/test_functions.vim (2)
• M src/testdir/test_let.vim (23)
• M src/testdir/test_listdict.vim (2)
• M src/testdir/test_partial.vim (12)
• M src/testdir/test_usercommands.vim (4)

Patch Links:

• https://github.com/vim/vim/pull/5976.patch
• https://github.com/vim/vim/pull/5976.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[Dominique Pellé]

@dpelle commented on this pull request.

---

In src/testdir/test_expr.vim:

> @@ -583,4 +585,14 @@ func Test_expr_eval_error()
   call assert_fails("let v = -{}", 'E728:')
 endfunc
 
+" Test for float value comparison
+func Test_float_compare()
+  call assert_true(1.2 == 1.2)
+  call assert_true(1.0 != 1.2)
+  call assert_true(1.2 > 1.0)
+  call assert_true(1.2 >= 1.2)
+  call assert_true(1.0 < 1.2)
+  call assert_true(1.2 <= 1.2)

How about testing:

• NaN (which is never equal to anything, including itself)
• +infinity
• -infinity
• +0.0 and -0.0 (which should be equal despite having different representation)

[Yegappan Lakshmanan]

Hi Dominique,

On Fri, Apr 24, 2020 at 10:18 AM Dominique Pellé <vim-dev...@256bit.org> wrote:

@dpelle commented on this pull request.

---

In src/testdir/test_expr.vim:

> @@ -583,4 +585,14 @@ func Test_expr_eval_error()
   call assert_fails("let v = -{}", 'E728:')
 endfunc
 
+" Test for float value comparison
+func Test_float_compare()
+  call assert_true(1.2 == 1.2)
+  call assert_true(1.0 != 1.2)
+  call assert_true(1.2 > 1.0)
+  call assert_true(1.2 >= 1.2)
+  call assert_true(1.0 < 1.2)
+  call assert_true(1.2 <= 1.2)

How about testing:

• NaN (which is never equal to anything, including itself)
• +infinity
• -infinity
• +0.0 and -0.0 (which should be equal despite having different representation)

I will add these cases.

Thanks,

Yegappan 

[vim-dev ML]

Hi Dominique,

On Fri, Apr 24, 2020 at 10:18 AM Dominique Pellé <vim-dev...@256bit.org>
wrote:

> *@dpelle* commented on this pull request.
> ------------------------------
>
> In src/testdir/test_expr.vim
> <https://github.com/vim/vim/pull/5976#discussion_r414735853>:

>
> > @@ -583,4 +585,14 @@ func Test_expr_eval_error()
> call assert_fails("let v = -{}", 'E728:')
> endfunc
>
> +" Test for float value comparison
> +func Test_float_compare()
> + call assert_true(1.2 == 1.2)
> + call assert_true(1.0 != 1.2)
> + call assert_true(1.2 > 1.0)
> + call assert_true(1.2 >= 1.2)
> + call assert_true(1.0 < 1.2)
> + call assert_true(1.2 <= 1.2)
>
> How about testing:
>

> - NaN (which is never equal to anything, including itself)
> - +infinity
> - -infinity
> - +0.0 and -0.0 (which should be equal despite having different

> representation)
>
>
I will add these cases.

Thanks,
Yegappan

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• c16bbbb Update tests

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

[Bram Moolenaar]

Closed #5976 via 9d8d0b5.

—
You are receiving this because you commented.