[vim/vim] WIP: Add tests for handling mouse in a terminal (#6052)

25 views
Skip to first unread message

Yegappan Lakshmanan

unread,
May 8, 2020, 9:55:32 PM5/8/20
to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/6052

Commit Summary

  • Add tests for handling mouse in a terminal.

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yegappan Lakshmanan

unread,
May 9, 2020, 12:20:18 AM5/9/20
to vim/vim, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Yegappan Lakshmanan

unread,
May 9, 2020, 1:07:28 AM5/9/20
to vim/vim, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
May 9, 2020, 8:52:28 PM5/9/20
to vim/vim, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Codecov

unread,
May 9, 2020, 9:19:26 PM5/9/20
to vim/vim, Subscribed

Codecov Report

Merging #6052 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@

##           master    #6052      +/-   ##

==========================================

+ Coverage   87.09%   87.18%   +0.09%     

==========================================

  Files         142      142              

  Lines      156612   156609       -3     

==========================================

+ Hits       136395   136542     +147     

+ Misses      20217    20067     -150
Impacted Files Coverage Δ
src/vim9execute.c 92.26% <0.00%> (-1.61%) ⬇️
src/gui.c 63.30% <0.00%> (-0.56%) ⬇️
src/sign.c 94.77% <0.00%> (-0.26%) ⬇️
src/gui_gtk_x11.c 57.73% <0.00%> (-0.10%) ⬇️
src/os_unix.c 69.56% <0.00%> (-0.02%) ⬇️
src/window.c 89.26% <0.00%> (ø)
src/version.c 92.13% <0.00%> (ø)
src/userfunc.c 93.09% <0.00%> (+<0.01%) ⬆️
src/evalvars.c 95.26% <0.00%> (+0.01%) ⬆️
src/screen.c 85.35% <0.00%> (+0.04%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d131b0...3257637. Read the comment docs.

Yegappan Lakshmanan

unread,
May 9, 2020, 11:08:55 PM5/9/20
to vim/vim, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
May 10, 2020, 2:15:21 AM5/10/20
to vim/vim, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
May 10, 2020, 11:58:45 AM5/10/20
to vim/vim, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
May 10, 2020, 2:10:21 PM5/10/20
to vim/vim, Push

@yegappan pushed 1 commit.

  • 1fca34f Fix MS-Windows test failure

—
You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,
May 10, 2020, 3:26:40 PM5/10/20
to vim/vim, Subscribed

Just one test is failing. Is it flaky?

Yegappan Lakshmanan

unread,
May 10, 2020, 3:59:52 PM5/10/20
to vim_dev, reply+ACY5DGDLN446S4E43G...@reply.github.com, vim/vim, Subscribed
Hi Bram,

On Sun, May 10, 2020 at 12:26 PM Bram Moolenaar <vim-dev...@256bit.org> wrote:

Just one test is failing. Is it flaky?



The failing list is pasting text using the middle mouse button in a terminal
window. In the failed case, instead of pasting the '*' register, it pasted the '+' register.
In all the other previous runs and other test runs, this test is passing. I am not sure
why in this particular run this test failed.

Regards,
Yegappan
 

vim-dev ML

unread,
May 10, 2020, 4:00:13 PM5/10/20
to vim/vim, vim-dev ML, Your activity

Bram Moolenaar

unread,
May 10, 2020, 5:33:30 PM5/10/20
to vim/vim, vim-dev ML, Comment

If it's about using the selection, perhaps some X request was delayed? Just guessing.

—
You are receiving this because you commented.

Yegappan Lakshmanan

unread,
May 10, 2020, 9:12:12 PM5/10/20
to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

  • 0f67d55 Use a register to paste text instead of the clipboard

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
May 11, 2020, 1:18:53 AM5/11/20
to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
May 11, 2020, 11:40:01 AM5/11/20
to vim_dev, reply+ACY5DGGO6UAXCBOB2N...@reply.github.com, vim/vim, vim-dev ML, Comment
Hi Bram,

On Sun, May 10, 2020 at 2:33 PM Bram Moolenaar <vim-dev...@256bit.org> wrote:

If it's about using the selection, perhaps some X request was delayed? Just guessing.



I addressed this problem by using a normal register instead of the clipboard
to paste using the middle mouse button.

- Yegappan
 

vim-dev ML

unread,
May 11, 2020, 11:40:23 AM5/11/20
to vim/vim, vim-dev ML, Your activity

Yegappan Lakshmanan

unread,
May 11, 2020, 12:38:48 PM5/11/20
to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
May 11, 2020, 1:04:28 PM5/11/20
to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
May 11, 2020, 1:45:49 PM5/11/20
to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

  • 1f8bc89 Wait for the terminal buffer update to complete

—
You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,
May 11, 2020, 4:05:25 PM5/11/20
to vim/vim, vim-dev ML, Comment

Closed #6052 via 91689ea.

—
You are receiving this because you commented.

Reply all
Reply to author
Forward
0 new messages