[vim/vim] Fix leak of terminal_bufs (#6935)
Rob Pilling
A follow-up to #6930 / 0e65511 - fix the leak of the second terminal_bufs
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/6935
Commit Summary
- Fix leak of terminal_bufs
File Changes
- M src/session.c (3)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Yegappan Lakshmanan
A follow-up to #6930 / 0e65511 - fix the leak of the second
terminal_bufs
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/6935
Commit Summary
- Fix leak of terminal_bufs
File Changes
- M src/session.c (3)
Patch Links:
vim-dev ML
> <https://github.com/vim/vim/commit/0e655111e9dbdbdf69fee1b199f2b9c355bf4a10>
> - fix the leak of the second terminal_bufs
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/vim/vim/pull/6935
> Commit Summary
>
>
> File Changes
>
> - *M* src/session.c
> <https://github.com/vim/vim/pull/6935/files#diff-c4be88194b2ccabe7ff34fece6d27ca7>
> (3)
>
> Patch Links:
>
> - https://github.com/vim/vim/pull/6935.patch
> - https://github.com/vim/vim/pull/6935.diff
>
>
>
As this memory leak was not caught by the existing test, it will be useful
to
add another test that catches this memory leak.
Thanks,
Yegappan
codecov[bot]
Codecov Report
Merging #6935 into master will decrease coverage by
0.22%.
The diff coverage is100.00%.
@@ Coverage Diff @@ ## master #6935 +/- ## ========================================== - Coverage 88.20% 87.97% -0.23% ========================================== Files 148 147 -1 Lines 161191 160345 -846 ========================================== - Hits 142174 141064 -1110 - Misses 19017 19281 +264
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/session.c | 82.05% <100.00%> (+0.36%) |
⬆️ |
| src/libvterm/src/rect.h | 0.00% <0.00%> (-96.56%) |
⬇️ |
| src/libvterm/src/state.c | 49.49% <0.00%> (-40.50%) |
⬇️ |
| src/libvterm/include/vterm.h | 0.00% <0.00%> (-37.50%) |
⬇️ |
| src/libvterm/src/pen.c | 50.73% <0.00%> (-33.93%) |
⬇️ |
| src/libvterm/src/keyboard.c | 55.78% <0.00%> (-32.64%) |
⬇️ |
| src/libvterm/src/encoding.c | 44.55% <0.00%> (-27.73%) |
⬇️ |
| src/libvterm/src/vterm.c | 48.13% <0.00%> (-18.54%) |
⬇️ |
| src/libvterm/src/parser.c | 84.31% <0.00%> (-10.79%) |
⬇️ |
| src/libvterm/src/mouse.c | 41.66% <0.00%> (-6.67%) |
⬇️ |
| ... and 54 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 14944c0...894f2e0. Read the comment docs.
—
You are receiving this because you commented.
Bram Moolenaar
I think we can actually drop that hashtab when executing :mkview. Oh, I already done it now..
—
You are receiving this because you commented.
Rob Pilling
Ah yes, this makes sense. Thanks!
—
You are receiving this because you commented.