Patch 8.2.1195

9 views
Skip to first unread message

Bram Moolenaar

unread,
Jul 12, 2020, 2:00:58 PM7/12/20
to vim...@googlegroups.com

Patch 8.2.1195
Problem: Clientserver test fails on MS-Windows.
Solution: Expect a different error message.
Files: src/testdir/test_clientserver.vim


*** ../vim-8.2.1194/src/testdir/test_clientserver.vim 2020-07-11 22:14:54.310422225 +0200
--- src/testdir/test_clientserver.vim 2020-07-12 19:58:34.098298980 +0200
***************
*** 166,173 ****

call assert_fails('call remote_startserver([])', 'E730:')
call assert_fails("let x = remote_peek([])", 'E730:')
! call assert_fails("let x = remote_read('vim10')", ['E573:.*vim10'])
! call assert_fails("call server2client('abc', 'xyz')", ['E573:.*abc'])
endfunc

" Uncomment this line to get a debugging log
--- 166,175 ----

call assert_fails('call remote_startserver([])', 'E730:')
call assert_fails("let x = remote_peek([])", 'E730:')
! call assert_fails("let x = remote_read('vim10')",
! \ [has('unix') ? 'E573:.*vim10' : 'E277:.*vim10'])
! call assert_fails("call server2client('abc', 'xyz')",
! \ [has('unix') ? 'E573:.*abc' : 'E258:.*abc'])
endfunc

" Uncomment this line to get a debugging log
*** ../vim-8.2.1194/src/version.c 2020-07-12 19:52:32.707024154 +0200
--- src/version.c 2020-07-12 19:59:22.942230315 +0200
***************
*** 756,757 ****
--- 756,759 ----
{ /* Add new patch number below this line */
+ /**/
+ 1195,
/**/

--
hundred-and-one symptoms of being an internet addict:
18. Your wife drapes a blond wig over your monitor to remind you of what she
looks like.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Yegappan Lakshmanan

unread,
Jul 12, 2020, 2:18:16 PM7/12/20
to vim_dev
Hi,

On Sun, Jul 12, 2020 at 11:00 AM Bram Moolenaar <Br...@moolenaar.net> wrote:

Patch 8.2.1195
Problem:    Clientserver test fails on MS-Windows.
Solution:   Expect a different error message.
Files:      src/testdir/test_clientserver.vim


The test still fails as the matching pattern is not correct. The output has the following
messages:

E277: Unable to read a server reply
E258: Unable to send to client

But the test is trying to match these messages against  'E277:.*vim10' and
'E258:.*abc'.

Regards,
Yegappan

Bram Moolenaar

unread,
Jul 12, 2020, 4:07:42 PM7/12/20
to vim...@googlegroups.com, Yegappan Lakshmanan

Yegappan wrote:

> On Sun, Jul 12, 2020 at 11:00 AM Bram Moolenaar <Br...@moolenaar.net> wrote:
>
> >
> > Patch 8.2.1195
> > Problem: Clientserver test fails on MS-Windows.
> > Solution: Expect a different error message.
> > Files: src/testdir/test_clientserver.vim
> >
> >
> The test still fails as the matching pattern is not correct. The output has
> the following
> messages:
>
> E277: Unable to read a server reply
> E258: Unable to send to client
>
> But the test is trying to match these messages against 'E277:.*vim10' and
> 'E258:.*abc'.

Yeah, the output shows more, but that's what the assert code adds.
Ideally the code is changed to give the same error message, no matter
the system.

--
hundred-and-one symptoms of being an internet addict:
20. When looking at a pageful of someone else's links, you notice all of them
are already highlighted in purple.
Reply all
Reply to author
Forward
0 new messages