[vim/vim] Add v:exiting variable to get the Vim exit code (#7395)

[Yegappan Lakshmanan]

Port the support for v:exiting variable from Neovim:

neovim/neovim#5651
neovim/neovim@d2e8c76

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/7395

Commit Summary

• Add v:exiting variable to get the Vim exit code

File Changes

• M runtime/doc/autocmd.txt (2)
• M runtime/doc/eval.txt (7)
• M src/evalvars.c (3)
• M src/main.c (5)
• M src/testdir/test_exit.vim (27)
• M src/vim.h (3)

Patch Links:

• https://github.com/vim/vim/pull/7395.patch
• https://github.com/vim/vim/pull/7395.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[codecov[bot]]

Codecov Report

❗ No coverage uploaded for pull request base (master@23515b4). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@

##             master    #7395   +/-   ##

=========================================

  Coverage          ?   88.88%           

=========================================

  Files             ?      148           

  Lines             ?   163113           

  Branches          ?        0           

=========================================

  Hits              ?   144984           

  Misses            ?    18129           

  Partials          ?        0           

Impacted Files	Coverage Δ
src/evalvars.c	95.80% <100.00%> (ø)
src/main.c	87.32% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23515b4...e986ff0. Read the comment docs.

[Bram Moolenaar]

Shouldn't the entry in vimvars[] use VAR_SPECIAL? the value is v:null until it's set to a number.

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• 95d3412 Convert type of v:exiting variable to VAR_SPECIAL

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

[Yegappan Lakshmanan]

On Sun, Nov 29, 2020 at 11:57 AM Bram Moolenaar <vim-dev...@256bit.org> wrote:

Shouldn't the entry in vimvars[] use VAR_SPECIAL? the value is v:null until it's set to a number.

I have updated the PR to use VAR_SPECIAL type for v:exiting.

Does anyone think we should rename this variable to v:exitval? This will not be

compatible with Neovim though.

Regards,

Yegappan

 

[vim-dev ML]

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• e6dd23a Update help

—
You are receiving this because you are subscribed to this thread.

[Christian Brabandt]

On So, 29 Nov 2020, Yegappan Lakshmanan wrote:

> Does anyone think we should rename this variable to v:exitval? This
> will not be compatible with Neovim though.

While I think v:exitval describes it better, I don't think we should
change this and be incompatible with Neovim.

Best,
Christian
--
Lieber arm dran als Arm ab.

[James McCoy]

Does anyone think we should rename this variable to v:exitval?

The initial naming was suggested to mirror v:dying. There were some better names, including exitval, suggested while working on the changes, but unfortunately v:exiting is what was eventually committed.

This will not be compatible with Neovim though.

It'd be nice to avoid gratuitous incompatibilities between the two.

—
You are receiving this because you commented.

[Bram Moolenaar]

Closed #7395 via f0068c5.

—
You are receiving this because you commented.