Re: [PATCH] fix: powershell :! filter commands

[Bram Moolenaar]

[cc'ing vim-dev]

Enan Ajmain wrote:

> Problem: filtered bang commands with powershell as `:set shell` doesn't
> work. The command structure followed in `make_filter_cmd` is wrong. Try
> `:%!sort` on any file to reproduce the bug.
>
> Solution: Fix the command for the powershell in `make_filter_cmd`.
>
> This is not a proper patch. It comes originally from my neovim PR. I
> just wanted to see if it would work in vim. It does.
>
> I'm not sending it to vim...@googlegroups.com because it's not a proper
> patch: I haven't added any tests; haven't changed the docs or the
> default config sources. I'm hoping someone in the dev team, who at least
> sometimes works with a Windows machine, will take it up and police it.
>
> Here are the configurations for `:set shell=pwsh` this patch worked on:
>
> let &shellcmdflag = "-Command"
> let &shellredir = "2>&1 | Out-File -Encoding default %s; exit $LastExitCode"
> let &shellpipe = "2>&1 | Out-File -Encoding default %s; exit $LastExitCode"
> let &shellquote = ""
> let &shellxquote = "\""

Thanks for looking into this.

Would be good if this can be turned into a PR. Hopefully with a test.
Can you do that, or would this need to be done by someone else?
Then it's easier for others to comment and suggest improvements.

--
hundred-and-one symptoms of being an internet addict:
240. You think Webster's Dictionary is a directory of WEB sites.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Yegappan Lakshmanan]

Hi,

On Sat, Oct 1, 2022 at 8:04 AM Enan Ajmain <3nan....@gmail.com> wrote:

>
> On Sat, 01 Oct 2022 15:47:40 +0100
> Bram Moolenaar <Br...@moolenaar.net> wrote:
>
>
> > Would be good if this can be turned into a PR. Hopefully with a test.
> > Can you do that, or would this need to be done by someone else?
>

> I can't, sorry. Tests take a long time if one is not familiar with the
> suite beforehand.
>
> I can write what needs to be tested, though. In words. If anyone would
> take it on themself, I can help. But can't actually code the tests
> myself.
>

I have created PR https://github.com/vim/vim/pull/11257 with this patch
and a test.

- Yegappan