[vim/vim] Fix for test failures in MS-Windows (#7346)
Yegappan Lakshmanan
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/7346
Commit Summary
- Fix for test failures in MS-Windows
File Changes
- M src/testdir/test_channel.vim (10)
- M src/testdir/test_ex_mode.vim (1)
- M src/testdir/test_functions.vim (9)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
codecov[bot]
Codecov Report
Merging #7346 (2d278d1) into master (6abdcf8) will decrease coverage by
0.00%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #7346 +/- ## ========================================== - Coverage 88.89% 88.88% -0.01% ========================================== Files 148 148 Lines 162910 162910 ========================================== - Hits 144812 144797 -15 - Misses 18098 18113 +15
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/ex_getln.c | 91.32% <0.00%> (-0.40%) |
⬇️ |
| src/netbeans.c | 84.26% <0.00%> (-0.30%) |
⬇️ |
| src/getchar.c | 86.13% <0.00%> (-0.29%) |
⬇️ |
| src/search.c | 92.59% <0.00%> (-0.10%) |
⬇️ |
| src/sign.c | 94.94% <0.00%> (-0.09%) |
⬇️ |
| src/gui_gtk_x11.c | 58.76% <0.00%> (-0.05%) |
⬇️ |
| src/message.c | 88.86% <0.00%> (+0.04%) |
⬆️ |
| src/gui.c | 63.45% <0.00%> (+0.04%) |
⬆️ |
| src/channel.c | 90.08% <0.00%> (+0.05%) |
⬆️ |
| src/gui_gtk.c | 31.67% <0.00%> (+0.27%) |
⬆️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 6abdcf8...2d278d1. Read the comment docs.
K.Takata
@k-takata commented on this pull request.
In src/testdir/test_functions.vim:
> + " Maximum length of a filename (including the path) in MS-Windows is 255 + " characters. Make sure the length of the temp filename is < 255. + let len = 255 - getcwd()->len() - 6
The maximum length of a pathname is 259, and the maximum length of a file name without the path is 255.
Yegappan Lakshmanan
@k-takata commented on this pull request.
In src/testdir/test_functions.vim:
> + " Maximum length of a filename (including the path) in MS-Windows is 255 + " characters. Make sure the length of the temp filename is < 255. + let len = 255 - getcwd()->len() - 6The maximum length of a pathname is 259, and the maximum length of a file name without the path is 255.
vim-dev ML
> ------------------------------
>
> In src/testdir/test_functions.vim
> <https://github.com/vim/vim/pull/7346#discussion_r528412995>:
>
> > + " Maximum length of a filename (including the path) in MS-Windows is 255
> + " characters. Make sure the length of the temp filename is < 255.
> + let len = 255 - getcwd()->len() - 6
>
> The maximum length of a pathname is 259, and the maximum length of a file
> name without the path is 255.
>
>
>
According to this page:
https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
the maximum length of a file path is MAX_PATH (260) which includes the
driver letter,
directory names, path separators and the file name. To be on the safe side,
I chose
255. I can change it to 260.
Regards,
Yegappan
K.Takata
MAX_PATH includes the terminating NUL character, so the usable length is 259.
To be on the safe side, I chose 255.
ok, understand.
—
You are receiving this because you commented.
