[vim/vim] correctly draw number column in right-left mode (#8391)

8 views
Skip to first unread message

Christian Brabandt

unread,
Jun 16, 2021, 8:47:34 AM6/16/21
to vim/vim, Subscribed

fix for #8389

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/8391

Commit Summary

  • correctly draw number column in right-left mode

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

codecov[bot]

unread,
Jun 16, 2021, 8:50:01 AM6/16/21
to vim/vim, Subscribed

Codecov Report

Merging #8391 (274802f) into master (b90ac5e) will decrease coverage by 87.30%.
The diff coverage is 0.00%.

❗ Current head 274802f differs from pull request most recent head ce1909c. Consider uploading reports for the commit ce1909c to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@

##           master    #8391       +/-   ##

===========================================

- Coverage   89.81%    2.50%   -87.31%     

===========================================

  Files         149      147        -2     

  Lines      167465   162298     -5167     

===========================================

- Hits       150407     4068   -146339     

- Misses      17058   158230   +141172
Flag Coverage Δ
huge-clang-none ?
huge-gcc-none ?
huge-gcc-testgui ?
huge-gcc-unittests 2.50% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/drawline.c 0.00% <0.00%> (-85.30%) ⬇️
src/float.c 0.00% <0.00%> (-98.91%) ⬇️
src/sha256.c 0.00% <0.00%> (-97.96%) ⬇️
src/digraph.c 0.00% <0.00%> (-97.78%) ⬇️
src/gui_gtk_f.c 0.00% <0.00%> (-97.54%) ⬇️
src/match.c 0.00% <0.00%> (-97.13%) ⬇️
src/crypt_zip.c 0.00% <0.00%> (-97.06%) ⬇️
src/evalbuffer.c 0.00% <0.00%> (-96.83%) ⬇️
src/cmdhist.c 0.00% <0.00%> (-96.63%) ⬇️
src/debugger.c 0.00% <0.00%> (-96.62%) ⬇️
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90ac5e...ce1909c. Read the comment docs.

Yegappan Lakshmanan

unread,
Jun 16, 2021, 10:13:01 AM6/16/21
to vim_dev, reply+ACY5DGC6G67TUHKWNH...@reply.github.com, Subscribed
Hi Christian,

On Wed, Jun 16, 2021 at 5:47 AM Christian Brabandt <vim-dev...@256bit.org> wrote:

fix for #8389

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/8391

Commit Summary

  • correctly draw number column in right-left mode

File Changes

Patch Links:



I am attaching a test for this.

- Yegappan 
rlnumber.diff

vim-dev ML

unread,
Jun 16, 2021, 10:13:26 AM6/16/21
to vim/vim, vim-dev ML, Your activity

Hi Christian,

On Wed, Jun 16, 2021 at 5:47 AM Christian Brabandt <
***@***.***> wrote:

> fix for #8389 <https://github.com/vim/vim/issues/8389>
> ------------------------------

> You can view, comment on, or merge this pull request online at:
>
> https://github.com/vim/vim/pull/8391
> Commit Summary
>
> - correctly draw number column in right-left mode
>
> File Changes
>
> - *M* src/drawline.c
> <https://github.com/vim/vim/pull/8391/files#diff-15009492c2b1d0a2629908b4618ad51c99d16746f238a0e6451dfe32355ed32f>
> (5)
>
> Patch Links:
>
> - https://github.com/vim/vim/pull/8391.patch
> - https://github.com/vim/vim/pull/8391.diff

>
>
>
I am attaching a test for this.

- Yegappan

Bram Moolenaar

unread,
Jun 16, 2021, 10:26:54 AM6/16/21
to vim/vim, vim-dev ML, Comment

Christian - can you include the test in your PR?

—
You are receiving this because you commented.

Christian Brabandt

unread,
Jun 16, 2021, 10:31:06 AM6/16/21
to vim_dev

On Mi, 16 Jun 2021, Yegappan Lakshmanan wrote:

> I am attaching a test for this.

Oh wow, I wasn't so fast yet, just wanted to get feedback from the CI
system first.

Thanks for that, will amend the PR later

Best,
Christian
--
Neue Meldungen von Windows 2000:
Drücken Sie eine beliebige Taste außer... nein, Nein, NEIN, NICHT
DIE DA!

vim-dev ML

unread,
Jun 16, 2021, 10:31:59 AM6/16/21
to vim/vim, vim-dev ML, Your activity


On Mi, 16 Jun 2021, Bram Moolenaar wrote:

> Christian - can you include the test in your PR?

Of course. Just give me a couple of more hours of getting some real work
done :)

Best,
Christian
--
Hinter jedem großen Mann steckt eine Frau, die ihn dressiert hat.

Christian Brabandt

unread,
Jun 16, 2021, 12:10:50 PM6/16/21
to vim/vim, vim-dev ML, Push

@chrisbra pushed 1 commit.

  • a63433b add test for right-left number feature

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Yegappan Lakshmanan

unread,
Jun 16, 2021, 12:42:00 PM6/16/21
to vim_dev, nor...@github.com, vim/vim, vim-dev ML, Push
Hi Christian,

On Wed, Jun 16, 2021 at 9:10 AM Christian Brabandt <vim-dev...@256bit.org> wrote:

@chrisbra pushed 1 commit.

  • a63433b add test for right-left number feature



I missed adding a "CheckFeature rightleft" at the beginning of
the test.

- Yegappan
 

Christian Brabandt

unread,
Jun 16, 2021, 12:51:09 PM6/16/21
to vim/vim, vim-dev ML, Push

@chrisbra pushed 1 commit.

  • c0063fa add test for right-left number feature

—
You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,
Jun 16, 2021, 1:29:02 PM6/16/21
to vim/vim, vim-dev ML, Comment

Closed #8391 via 29f0dc3.

—
You are receiving this because you commented.

Reply all
Reply to author
Forward
0 new messages