[vim/vim] Fix signcolumn=number (#4694)

[mattn]

When number signcolumn=number, multi-byte sign text is broken.

set number

set signcolumn=number

sign define test1 text=山

sign define test2 text=a

sign place 2 line=10 name=test1

sign place 2 line=11 name=test2







"xxx

"xxx

"

Current behavior

Fixed

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/4694

Commit Summary

• Fix signcolumn=number
• Add test

File Changes

• M src/screen.c (5)
• M src/testdir/test_signs.vim (7)

Patch Links:

• https://github.com/vim/vim/pull/4694.patch
• https://github.com/vim/vim/pull/4694.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[mattn]

This should be right-aligned?

[Codecov]

Codecov Report

Merging #4694 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@

##           master    #4694      +/-   ##

==========================================

- Coverage   81.36%   81.32%   -0.04%     

==========================================

  Files         114      110       -4     

  Lines      145118   144855     -263     

==========================================

- Hits       118076   117808     -268     

- Misses      27042    27047       +5

Impacted Files	Coverage Δ
src/screen.c	82.33% <100%> (ø)	⬆️
src/gui_beval.c	62.5% <0%> (-0.87%)	⬇️
src/if_xcmdsrv.c	85.99% <0%> (-0.36%)	⬇️
src/message.c	76.75% <0%> (-0.25%)	⬇️
src/memfile.c	78.03% <0%> (-0.21%)	⬇️
src/mbyte.c	66.1% <0%> (-0.2%)	⬇️
src/terminal.c	81.21% <0%> (-0.12%)	⬇️
src/window.c	87.3% <0%> (-0.1%)	⬇️
src/gui_gtk_x11.c	57.91% <0%> (-0.05%)	⬇️
src/json_test.c
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acf7544...c0b09d3. Read the comment docs.

[mattn]

@mattn pushed 1 commit.

• d3ef4cc Use mb_string2cells

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

[mattn]

@mattn pushed 1 commit.

• c8f4d7d text size is always fixed

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

[Bram Moolenaar]

Closed #4694 via d6bcff4.

[Yegappan Lakshmanan]

Hi,

Thanks for addressing this issue. I normally don't use multi-byte characters.

So I couldn't test placing multi-byte signs in the number column.

Regards,

Yegappan

[vim-dev ML]

Hi,

Thanks for addressing this issue. I normally don't use multi-byte
characters.
So I couldn't test placing multi-byte signs in the number column.

Regards,
Yegappan

On Wed, Jul 17, 2019 at 11:05 PM mattn <vim-dev...@256bit.org> wrote:

> When number signcolumn=number, multi-byte sign text is broken.
>
> set number
> set signcolumn=number
> sign define test1 text=山
> sign define test2 text=a
> sign place 2 line=10 name=test1
> sign place 2 line=11 name=test2
>
>
>
>
>
>
> "xxx
> "xxx
> "
>
> Current behavior
> [image: image]

> <https://user-images.githubusercontent.com/10111/61433075-4b37fa80-a96d-11e9-9ae5-e10b02c3b3f7.png>
>
> Fixed
> [image: image]
> <https://user-images.githubusercontent.com/10111/61433109-6276e800-a96d-11e9-9739-fb1633adc9d2.png>
> ------------------------------

> You can view, comment on, or merge this pull request online at:
>
> https://github.com/vim/vim/pull/4694
> Commit Summary
>

> - Fix signcolumn=number
> - Add test
>
> File Changes
>
> - *M* src/screen.c <https://github.com/vim/vim/pull/4694/files#diff-0>
> (5)
> - *M* src/testdir/test_signs.vim
> <https://github.com/vim/vim/pull/4694/files#diff-1> (7)
>
> Patch Links:
>
> - https://github.com/vim/vim/pull/4694.patch
> - https://github.com/vim/vim/pull/4694.diff