[vim/vim] compile_def_function() is too long. Move out the code to compile the body of a function (PR #14622)

[Yegappan Lakshmanan]

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/14622

Commit Summary

• 9f629cc compile_def_function() is too long. Move out the code to compile the body of a function

File Changes

(3 files)

• M src/testdir/test_vim9_builtin.vim (2)
• M src/vim9compile.c (704)
• M src/vim9type.c (24)

Patch Links:

• https://github.com/vim/vim/pull/14622.patch
• https://github.com/vim/vim/pull/14622.diff

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/14622@github.com>

[Christian Brabandt]

thanks!

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/14622/c2073078578@github.com>

[Christian Brabandt]

Closed #14622 via a16f251.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/14622/issue_event/12579785038@github.com>

[Christian Brabandt]

Hi Yegappan,
Coverity complains about this one here however: https://scan5.scan.coverity.com/#/project-view/41242/10101?selectedIssue=1596610

I think this is a false positive?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/14622/c2074192811@github.com>

[Yegappan Lakshmanan]

Hi Christian,

On Tue, Apr 23, 2024 at 11:46 PM Christian Brabandt <vim-dev...@256bit.org> wrote:

Hi Yegappan,
Coverity complains about this one here however: https://scan5.scan.coverity.com/#/project-view/41242/10101?selectedIssue=1596610

I think this is a false positive?

Yes.  This is a false positive.  I ran a few tests to compile a def function with different types

of comments under valgrind to make sure that the vim9_bad_comment() function doesn't

perform an out-of-bounds access.  I also compared the code before and after the

refactoring to make sure that the logic is not changed.

Regards,

Yegappan

[vim-dev ML]

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/14622/c2075015252@github.com>

[Christian Brabandt]

Thanks. Yeah, I starred at it for a while, but it wasn't clear to me how the buffer could overrun. Thanks for double checking! I'll mark it as false positive then

—
Reply to this email directly, view it on GitHub.

You are receiving this because you commented.Message ID: <vim/vim/pull/14622/c2075511205@github.com>