test_codestyle failure

[Ernie Rael]

Earlier today I rebased and pushed a couple patches that were last pushed around a month ago (cleanly). Getting lots of test failures as shown below. Is there something I need to fix?

-ernie

Failures:

From test_codestyle.vim:

Found errors in Test_source_files():

command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[569]..function RunTheTest[52]..Test_source_files line 40: ../evalfunc.c: missing white space after "if"/"while"/"for": Expected 0 but got 642

command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[569]..function RunTheTest[52]..Test_source_files line 40: ../list.c: missing white space after "if"/"while"/"for": Expected 0 but got 2340

[Christ van Willegen]

Hi,

Op zo 4 jun. 2023 02:25 schreef Ernie Rael <err...@raelity.com>:

Check line 642 in evalfunc.c and line 2340 in list.c

You'll need to add a space before the (, probably...

Christ van Willegen

[Ernie Rael]

Doh! I psyched myself out. Given that it used to be OK, when I saw the "Expected 0", I thought it was a count.

Thanks,
-ernie

You'll need to add a space before the (, probably...

Christ van Willegen

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CA%2BOt1Oyd3n5TrrK2pB854FYRQpSXhi7EvrfYFv50%2Bk0czjJ9iQ%40mail.gmail.com.

[Bram Moolenaar]

> > Op zo 4 jun. 2023 02:25 schreef Ernie Rael <err...@raelity.com>:
> >
> > Earlier today I rebased and pushed a couple patches that were last
> > pushed around a month ago (cleanly). Getting lots of test failures
> > as shown below. Is there something I need to fix?
> >
> > -ernie
> >
> > Failures:
> > From test_codestyle.vim:
> > Found errors in Test_source_files():
> > command line..script
> > /home/runner/work/vim/vim/src/testdir/runtest.vim[569]..function
> > RunTheTest[52]..Test_source_files line 40: ../evalfunc.c: missing
> > white space after "if"/"while"/"for": Expected 0 but got 642
> > command line..script
> > /home/runner/work/vim/vim/src/testdir/runtest.vim[569]..function
> > RunTheTest[52]..Test_source_files line 40: ../list.c: missing
> > white space after "if"/"while"/"for": Expected 0 but got 2340
> >
> >
> > Check line 642 in evalfunc.c and line 2340 in list.c
>
> Doh! I psyched myself out. Given that it used to be OK, when I saw the
> "Expected 0", I thought it was a count.

I suppose the standard error message is a bit confusing here.
I'll change it to use assert_report() with a clearer message.

--
Nobody will ever need more than 640 kB RAM.
-- Bill Gates, 1983
Windows 98 requires 16 MB RAM.
-- Bill Gates, 1999
Logical conclusion: Nobody will ever need Windows 98.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///