Since recent commit getting E863: Not allowed for a terminal in a popup window

[M Kelly]

Hi,

Perhaps this was mentioned before ?

Since commit 5aed0ccb965dbad4b60f4c77c9c4455a9379e73c 

I am unable to use ag+fzf in a popup.  I get this error:

Error detected while processing function fzf#vim#grep[24]..<SNR>86_fzf[18]..fzf#run[58]..<SNR>66_execute_term:

line   70:

E863: Not allowed for a terminal in a popup window

before this commit it worked well.

I have the latest fzf and fzf.vim - do I need to submit a change to match latest vim api ?

Not sure yet what I need to change tho.

thx,

-m

[M Kelly]

Hi,

I think this is:

      let fzf.buf = term_start([&shell, &shellcmdflag, command], {'curwin': 1, 'exit_cb': function(fzf.on_exit)})

... trying to see what is in fzf.on_exit that might matter ?

thx,

-m

[M Kelly]

Hi,

Should I open a github issue for this ?
Seems there is similar info recently from lacygoill but not sure that is fully resolved ?

thx,

-m

[Bram Moolenaar]

Please find out what the command is where the error is triggered.
The usage of a terminal in a popup window was made more strict to fix a
bug. To see whether valid cases now run into this error we need to see
where exactly this happens.

--
From "know your smileys":
[:-) Frankenstein's monster

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[M Kelly]

Hi,

Someone else submitted an issue to fzf.vim for this 

https://github.com/junegunn/fzf.vim/issues/1028

I'll try to find the exact cmd that throws this later today.

thx!,

-m

[M Kelly]

Hi,

I think it has to do with calling term_start from within a popup.

I'll keep digging.

-m

[M Kelly]

Hi again,

I mean you said usage of a terminal in a popup has changed - and I can say this code calls term_start from a popup :-)

But I'm not yet clear on what is wrong with it.  I'll keep digging.

thx,

-m

[M Kelly]

Hi,

This issue is resolved in the latest fzf.vim commit d631c76e8d2dd18876a09d2c0919ece1a42a8721.

Thank you to those involved!

-m