[patch] Fix `make clean` error

17 views
Skip to first unread message

h_east

unread,
Jul 4, 2019, 9:41:56 PM7/4/19
to vim_dev
Hi Bram and list,

When execute `make clean` after `make test`, an error is output.
The attached patch fixes this.
Please confirm.

PS
testdir/Make_{dos,ming}.mak had already taken measures.

--------8<--------
$ make
[...]
$ make test
[...]
$ make clean
rm -rf *.out *.failed *.res *.rej *.orig
rm -f opt_test.vim test.log test_result.log messages
rm -f test.out X* viminfo tiny.vim small.vim mbyte.vim mzscheme.vim test.ok benchmark.out
rm: cannot remove 'XfakeHOME': Is a directory
Makefile:87: recipe for target 'clean' failed
make: [clean] Error 1 (ignored)
rm -f valgrind.*
--------8<--------

--
Best regards,
Hirohito Higashi (h_east)

fix_testdir_make_clean_error.patch

Bram Moolenaar

unread,
Jul 5, 2019, 2:44:18 PM7/5/19
to vim...@googlegroups.com, h_east

Hirohito Higashi wrote:

> When execute `make clean` after `make test`, an error is output.
> The attached patch fixes this.
> Please confirm.

Thanks. I had noticed that XfakeHOME was left behind, but had not
looked into fixing that yet.

> PS
> testdir/Make_{dos,ming}.mak had already taken measures.

I notice Make_amiga.mak deletes /tmp/*, that doesn't seem like a good
idea... Maybe it was OK when running one thing at a time, Amiga
replacements are more like Unix.


--
GUARD #1: What -- a swallow carrying a coconut?
ARTHUR: It could grip it by the husk!
GUARD #1: It's not a question of where he grips it! It's a simple question
of weight ratios! A five ounce bird could not carry a 1 pound
coconut.
The Quest for the Holy Grail (Monty Python)

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
Reply all
Reply to author
Forward
0 new messages