Regression using "-d" after 2027

[Aaron Heifetz]

After making 8.1.2033 (Windows 7, 64-bit MinGW) the display for the internal diff (external diff not tested) seems to be broken (8.1.2027 was ok):

8.1.2027:

8.1.2033 (mind the missing diff colors):

In the latter build, the internal diff colors appear, if the files's syntax colors are turned off (syntax off).

[Bram Moolenaar]

I cannot reproduce this. What diff highlighting are you using?
It looks like DiffChanged is not set.

--
XML is a nice language for computers. Not for humans.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Aaron Heifetz]

a) Haven't changed my .vimrc between the specified versions:

if has("patch-8.1.360")
    set diffopt=internal,filler,context:3,indent-heuristic,algorithm:minimal
else
...
endif

b) No difference in :scriptnames output.

c) :set all:

--- Options ---
  ambiwidth=single    clipboard=        nodiff                foldignore=#        imstatusfunc=       makeencoding=       pastetoggle=        selection=old       spellfile=        notextmode          novisualbell
noautochdir           cmdheight=1         diffexpr=           foldlevel=0         includeexpr=        makeprg=make        patchexpr=          selectmode=         spelllang=en        textwidth=190     nowarn
  autoindent          cmdwinheight=20   nodigraph             foldlevelstart=-1   incsearch           matchtime=5         patchmode=          shell=cmd.exe       spellsuggest=best   thesaurus=        noweirdinvert
noautoread            colorcolumn=        directory=d:\temp   foldmethod=manual   indentexpr=         maxcombine=2      nopreserveindent      shellcmdflag=/c   nosplitbelow          tildeop             wildchar=<Tab>
noautowrite           columns=226         display=lastline    foldminlines=0      infercase           maxfuncdepth=100    previewheight=12    shellquote=       nosplitright        notimeout             wildcharm=0
noautowriteall        comments=           eadirection=both    foldnestmax=20    noinsertmode          maxmapdepth=1000    previewpopup=     noshellslash        nostartofline         timeoutlen=1000   nowildignorecase
  background=light  nocompatible        noedcompatible        formatexpr=         isprint=@,~-255     maxmem=8240710    nopreviewwindow       shelltemp           suffixesadd=        title               wildmenu
nobackup              complete=.,b,i      emoji               formatprg=        nojoinspaces          maxmemtot=8240710   printdevice=        shellxquote=(     noswapfile            titlelen=85         wildmode=full
  backupcopy=auto     concealcursor=n     encoding=utf-8    nogdefault            key=                menuitems=25        prompt              shiftround          swapsync=fsync      titlestring=        wildoptions=
  backupext=~         conceallevel=0      endofline           guifontwide=        keymap=             modeline            pumheight=0         shiftwidth=3        switchbuf=        nottimeout            winaltkeys=no
  balloondelay=600    completefunc=       equalalways         guipty              keymodel=startsel nomodelineexpr        pumwidth=15         shortmess=aIOtT     synmaxcol=3000      ttimeoutlen=-1      wincolor=
noballooneval         completepopup=      equalprg=           guitablabel=%t      keywordprg=:help    modelines=5         quoteescape=\     noshortname           syntax=             ttybuiltin          window=80
  balloonexpr=      noconfirm           noerrorbells          guitabtooltip=      langmap=            modifiable        noreadonly            showbreak=>>        tabline=            ttyfast             winheight=1
  belloff=          nocopyindent          esckeys             helpheight=20       langmenu=none     nomodified            redrawtime=2000     showcmd             tabpagemax=10       ttyscroll=999     nowinfixheight
nobinary              cscopepathcomp=0    eventignore=        helplang=de       nolangnoremap         more                regexpengine=0      showfulltag         tabstop=3           undodir=.         nowinfixwidth
nobomb                cscopeprg=cscope    expandtab           hidden              langremap           mouse=a           norelativenumber    noshowmatch           tagbsearch        noundofile            winminheight=1
  breakindent       nocscoperelative    noexrc                history=600         laststatus=2      nomousefocus          remap             noshowmode            tagcase=followic    undolevels=500      winminwidth=1
  browsedir=buffer  nocscopetag           fileencoding=       hlsearch            lazyredraw          mousehide           report=0            showtabline=1       tagfunc=            undoreload=10000    winwidth=20
  bufhidden=          cscopetagorder=0    fileformat=unix     icon                linebreak           mousemodel=extend   restorescreen       sidescroll=25       taglength=0         updatecount=200   nowrap
  buflisted           cscopeverbose       fileignorecase      iconstring=         lines=81            mousetime=500     noruler               sidescrolloff=15    tagrelative         updatetime=4000     wrapmargin=0
  buftype=          nocursorbind          filetype=           ignorecase          linespace=1         number              rulerformat=        signcolumn=auto     tags=./tags,tags    varsofttabstop=     wrapscan
  cdpath=,,         nocursorcolumn      nofixendofline        imactivatefunc=   nolisp                numberwidth=4       scroll=26           smartcase           tagstack            vartabstop=         write
  cedit=^F          nocursorline          foldclose=        noimcmdline         nolist                omnifunc=         noscrollbind        nosmartindent         term=builtin_gui    verbose=0         nowriteany
  charconvert=        debug=              foldcolumn=0      noimdisable           loadplugins       noopendevice          scrolljump=1        smarttab            termencoding=       verbosefile=      nowritebackup
nocindent           nodelcombine          foldenable          iminsert=0          magic               operatorfunc=       scrolloff=5         softtabstop=0     noterse               viminfofile=        writedelay=0
  cinoptions=         dictionary=         foldexpr=0          imsearch=-1         makeef=           nopaste             nosecure            nospell               textauto            virtualedit=block
  backspace=eol,indent,start
  backupdir=.,d:\temp,c:\tmp,c:\temp
  backupskip=d:\temp\*,d:\temp\*
  breakat= ^I!@*-+;:,./?
  breakindentopt=sbr
  casemap=internal,keepascii
  cinkeys=0{,0},0),0],:,0#,!^F,o,O,e
  cinwords=if,else,while,do,for,switch
  commentstring=/*%s*/
  completeopt=menu,preview,longest
  completeslash=slash
  cpoptions=ABcfijs$
  cryptmethod=blowfish2
  cscopequickfix=s-,c-,d-,i-,t-,e-
  cursorlineopt=both
  define=^\s*#\s*define
  diffopt=internal,filler,context:3,indent-heuristic,algorithm:minimal
  errorfile=errors.err
  errorformat=%f(%l) \=: %t%*\D%n: %m,%*[^"]"%f"%*\D%l: %m,%f(%l) \=: %m,%*[^ ] %f %l: %m,%f:%l:%c:%m,%f(%l):%m,%f:%l:%m,%f|%l| %m
  fileencodings=ucs-bom,utf-8,latin1,koi8-r
  fileformats=unix,dos,mac
  fillchars=diff: ,vert: ,fold:-
  foldmarker={{{,}}}
  foldopen=block,mark,percent,quickfix,search,tag,undo
  foldtext=foldtext()
  formatoptions=cjnq
  formatlistpat=^\s*\d\+[\]:.)}\t ]\s*
  grepformat=%f:%l:%m
  grepprg=g:start_rg -Hn --no-heading'
  guicursor=n-v-c:block-Cursor/lCursor-blinkwait250-blinkon500-blinkoff500,i-ci:ver25-CursorModify/lCursor-blinkwait250-blinkon500-blinkoff500,r-cr:block-CursorModify/lCursor-blinkwait250-blinkon500-blinkoff500-,o:block-CursorWait-blinkon0,ve:ver25-Cursor
  guifont=DejaVu_Sans_Mono:h8
  guioptions=Abeghmrt
  helpfile=k:\bin\vim\doc\help.txt
  highlight=8:SpecialKey,~:EndOfBuffer,@:NonText,d:Directory,e:ErrorMsg,i:IncSearch,l:Search,m:MoreMsg,M:ModeMsg,n:LineNr,N:CursorLineNr,r:Question,s:StatusLine,S:StatusLineNC,c:VertSplit,t:Title,v:Visual,V:VisualNOS,w:WarningMsg,W:WildMenu,f:Folded,F:FoldColumn,A:DiffAdd,C:DiffChange,D:DiffDelete,T:DiffText,>:SignColumn,-:Conceal,B:SpellBad,P:SpellCap,R:SpellRare,L:SpellLocal,+:Pmenu,=:PmenuSel,x:PmenuSbar,X:PmenuThumb,*:TabLine,#:TabLineSel,_:TabLineFill,!:CursorColumn,.:CursorLine,o:ColorColumn,q:QuickFixLine,z:StatusLineTerm,Z:StatusLineTermNC
  include=^\s*#\s*include
  indentkeys=0{,0},0),0],:,0#,!^F,o,O,e
  isfname=@,48-57,/,\,.,-,_,+,,,#,$,%,{,},[,],:,@-@,!,~,=
  isident=@,48-57,_,128-167,224-235
  iskeyword=@,48-57,_,192-255
  lispwords=defun,define,defmacro,set!,lambda,if,case,let,flet,let*,letrec,do,do*,define-syntax,let-syntax,letrec-syntax,destructuring-bind,defpackage,defparameter,defstruct,deftype,defvar,do-all-symbols,do-external-symbols,do-symbols,dolist,dotimes,ecase,etypecase,eval-when,labels,macrolet,multiple-value-bind,multiple-value-call,multiple-value-prog1,multiple-value-setq,prog1,progv,typecase,unless,unwind-protect,when,with-input-from-string,with-open-file,with-open-stream,with-output-to-string,with-package-iterator,define-condition,handler-bind,handler-case,restart-bind,restart-case,with-simple-restart,store-value,use-value,muffle-warning,abort,continue,with-slots,with-slots*,with-accessors,with-accessors*,defclass,defmethod,print-unreadable-object
  listchars=tab:» ,trail:·,eol:$,nbsp:¯
  matchpairs=(:),[:],{:},<:>
  maxmempattern=1000
  mkspellmem=460000,2000,500
  mouseshape=i-r:beam,s:updown,sd:udsizing,vs:leftright,vd:lrsizing,m:no,ml:up-arrow,v:rightup-arrow
  nrformats=bin,octal,hex
  packpath=~/vimfiles,k:\bin\vim/vimfiles,k:\bin\vim,k:\bin\vim/vimfiles/after,~/vimfiles/after
  paragraphs=IPLPPPQPP TPHPLIPpLpItpplpipbp
  path=k:\bin\vim\.vim,k:\bin\vim,k:\bin\vim\.vim/colors,k:\bin\vim\.vim/indent,k:\bin\vim\.vim/keymap,k:\bin\vim\.vim/plugin,k:\bin\vim\.vim/scripts,k:\bin\vim\.vim/syntax,k:\bin\vim/syntax,k:\bin\vim\.vim/templates,k:\bin\vim/vimperator/colors
  printfont=DejaVu_Sans_Mono:h8
  printheader=%<%f%h%m%=Page %N
  printoptions=left:10mm,right:10mm,top:10mm,bottom:10mm,header:0,wrap:n,jobsplit:y,portrait:n
  runtimepath=k:\bin\vim\.vim,k:\bin\vim
  scrollopt=ver,jump,hor
  sections=SHNHH HUnhsh
  sessionoptions=curdir,options,resize,winpos,winsize
  shellpipe=>%s 2>&1
  shellredir=>%s 2>&1
  shellxescape="&|<>()@^
  spellcapcheck=[.?!]\_[\])'"^I ]\+
  statusline=%!Statusline()
  suffixes=.bak,~,.o,.h,.info,.swp,.obj
  titleold=Thanks for flying Vim
  ttytype=builtin_gui
  viewdir=k:\bin\vim/.vim/views
  viewoptions=folds,options,cursor,curdir
  viminfo='200,<50,nk:/bin/vim/.vim/../.viminfo
  whichwrap=b,s,h,l,<,>,[,]
  wildignore=*.a,*.dll,*.exe,*.o

[Aaron Heifetz]

a) Also tried with "-d -i NONE -N -u NONE --noplugin -U NONE .\Make_cyg_ming.mak .\Make_cyg_ming_ori.mak":

b) :ver shows:

VIM - Vi IMproved 8.1 (2018 May 18, compiled Sep 14 2019 11:20:52)
MS-Windows 64-bit GUI version
Included patches: 1-2027
Compiled by ...
Big version with GUI.  Features included (+) or not (-):
+acl                +cindent            +cursorshape        -farsi              +jumplist           +mksession          +path_extra         -ruby               -tag_old_static     +toolbar            +wildmenu
-arabic             +clientserver       +dialog_con_gui     +file_in_path       +keymap             +modify_fname       -perl               +scrollbind         -tag_any_white      +user_commands      +windows
+autocmd            +clipboard          +diff               +find_in_path       +lambda             +mouse              +persistent_undo    +signs              -tcl                +vartabs            +writebackup
+autochdir          +cmdline_compl      +digraphs           +float              +langmap            +mouseshape         -postscript         +smartindent        -termguicolors      +vertsplit          -xfontset
+autoservername     +cmdline_hist       -directx            +folding            +libcall            +multi_byte_ime/dyn +printer            +sound              -terminal           +virtualedit        -xim
+balloon_eval       +cmdline_info       -dnd                -footer             +linebreak          +multi_lang         -profile            +spell              -termresponse       +visual             +xpm_w32
-balloon_eval_term  +comments           -ebcdic             +gettext/dyn        +lispindent         -mzscheme           -python             +startuptime        +textobjects        +visualextra        -xterm_save
+browse             +conceal            +emacs_tags         -hangul_input       +listcmds           -netbeans_intg      -python3            +statusline         +textprop           +viminfo           
++builtin_terms     +cryptv             +eval               +iconv/dyn          +localmap           +num64              +quickfix           -sun_workshop       -tgetent            +vreplace          
+byte_offset        +cscope             +ex_extra           +insert_expand      -lua                -ole                +reltime            +syntax             +timers             -vtp               
+channel            +cursorbind         +extra_search       +job                +menu               +packages           -rightleft          +tag_binary         +title              +wildignore        
   system vimrc file: "$VIM\vimrc"
     user vimrc file: "$HOME\_vimrc"
 2nd user vimrc file: "$HOME\vimfiles\vimrc"
 3rd user vimrc file: "$VIM\_vimrc"
      user exrc file: "$HOME\_exrc"
  2nd user exrc file: "$VIM\_exrc"
  system gvimrc file: "$VIM\gvimrc"
    user gvimrc file: "$HOME\_gvimrc"
2nd user gvimrc file: "$HOME\vimfiles\gvimrc"
3rd user gvimrc file: "$VIM\_gvimrc"
       defaults file: "$VIMRUNTIME\defaults.vim"
    system menu file: "$VIMRUNTIME\menu.vim"
Compilation: gcc -I. -Iproto -DWIN32 -DWINVER=0x0600 -D_WIN32_WINNT=0x0600 -DHAVE_PATHDEF -DFEAT_BIG -DHAVE_STDINT_H -DMS_WIN64 -DHAVE_GETTEXT -DHAVE_LOCALE_H -DDYNAMIC_GETTEXT -DFEAT_CSCOPE -DFEAT_JOB_CHANNEL -DFEAT_SOUND -DFEAT_GUI_MSWIN -DFEAT_CLIPBOARD -DFEAT_MBYTE_IME -DDYNAMIC_IME -DDYNAMIC_ICONV -pipe -march=x86-64 -Wall -DFEAT_XPM_W32 -I xpm/x64/include -I xpm/x64/../include -O3 -fomit-frame-pointer -freg-struct-return
Linking: gcc -I. -Iproto -DWIN32 -DWINVER=0x0600 -D_WIN32_WINNT=0x0600 -DHAVE_PATHDEF -DFEAT_BIG -DHAVE_STDINT_H -DMS_WIN64 -DHAVE_GETTEXT -DHAVE_LOCALE_H -DDYNAMIC_GETTEXT -DFEAT_CSCOPE -DFEAT_JOB_CHANNEL -DFEAT_SOUND -DFEAT_GUI_MSWIN -DFEAT_CLIPBOARD -DFEAT_MBYTE_IME -DDYNAMIC_IME -DDYNAMIC_ICONV -pipe -march=x86-64 -Wall -DFEAT_XPM_W32 -I xpm/x64/include -I xpm/x64/../include -O3 -fomit-frame-pointer -freg-struct-return -s -municode -mwindows -o gvim.exe -lkernel32 -luser32 -lgdi32 -ladvapi32 -lcomdlg32 -lcomctl32 -lnetapi32 -lversion -lwsock32 -Lxpm/x64/lib -lXpm -lwinmm -lgcc_eh -Wl,-Bstatic -lwinpthread -Wl,-Bdynamic -lole32 -luuid     

[Bram Moolenaar]

Aaron Heifetz wrote:

> a) Haven't changed my .vimrc between the specified versions:
>
> if has("patch-8.1.360")

> set diffopt=3Dinternal,filler,context:3,indent-heuristic,algorithm:mini=
> mal

> else
> ...
> endif
>
> b) No difference in :scriptnames output.

Not what changed, but what you already had, since you are apparently not
using the default colors.

Please start with "vim --clean" and reproduce it with that. You
probably have some highlight commands that matter.


--
hundred-and-one symptoms of being an internet addict:
269. You receive an e-mail from the wife of a deceased president, offering
to send you twenty million dollar, and you are not even surprised.

[Bram Moolenaar]

Aaron Heifetz wrote:

> a) Also tried with "-d -i NONE -N -u NONE --noplugin -U NONE
> .\Make_cyg_ming.mak .\Make_cyg_ming_ori.mak":
>
>
> [image: 116.png]

OK, now I see what you mean. Strange that no screenshot test failed for
this.

It's already fixed with patch 8.1.2040.

--
hundred-and-one symptoms of being an internet addict:

270. You are subscribed to a mailing list for every piece of software
you use.