[vim/vim] Improve the Warnings about missing clipboard registers (PR #16069)
Christian Brabandt
- Make it translatable
- Use a different warning, when clipboard support was not compiled in
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/16069
Commit Summary
- 79403d8 Improve the Warnings about missing clipboard registers
File Changes
(4 files)
- M runtime/doc/gui.txt (4)
- M runtime/doc/gui_x11.txt (8)
- M src/message.c (7)
- M src/testdir/test_registers.vim (2)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra pushed 1 commit.
- e369514 Improve the Warnings about missing clipboard registers
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Luca Saccarola
@saccarosium requested changes on this pull request.
In src/message.c:
> @@ -4071,7 +4070,11 @@ msg_warn_missing_clipboard(void)
{
if (!global_busy && !did_warn_clipboard)
{
- msg(_(warn_clipboard));
+#ifdef FEAT_CLIPBOARD
+ msg(_("W23: Clipboard register not available, using register 0"));
+#else
+ msg(_("W24: Clipboard register not available"));
I think this should be a little more specific about the fact that vim doesn't have this functionality compiled with ideally a link to a doc detailing what is +clipboard. Mainly for new users that they will likely now about +clipboard and the fact that you need to recompile vim.
Probably something like: "Clipboard register is not available in this build of vim. To learn more read :h clipboard"
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Gary Johnson
> @saccarosium requested changes on this pull request.
>
> In src/message.c:
>
> > @@ -4071,7 +4070,11 @@ msg_warn_missing_clipboard(void)
> {
> if (!global_busy && !did_warn_clipboard)
> {
> - msg(_(warn_clipboard));
> +#ifdef FEAT_CLIPBOARD
> + msg(_("W23: Clipboard register not available, using register 0"));
> +#else
> + msg(_("W24: Clipboard register not available"));
>
> I think this should be a little more specific about the fact that vim doesn't
> have this functionality compiled with ideally a link to a doc detailing what is
> +clipboard. Mainly for new users that they will likely now about +clipboard and
> the fact that you need to recompile vim.
>
> Probably something like: "Clipboard register is not available in this build of
> vim. To learn more read :h clipboard"
I don't think we should be turning error messages into essays when
we have a very good help system.
Regards,
Gary
vim-dev ML
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Luca Saccarola
TLDR: at least try to tell the user why the clipboard is unavailable.
But new users should know about, or be made aware of, ":help W23".
IMHO Errors should be helpful and guide you to the solution. The all W* is not really user friendly TBH (but that is another discussion). If I'm a new user how I suppose to know that that W24 is a helptag to use in the docs? I've used vim for like 6 years and discovered this not even that long ago and I'm certain that will confuse people at least from my personal experience teaching vim and helping others triage issues.
I don't think we should be turning error messages into essays
Man you read really short essays :)
—
Reply to this email directly, view it on GitHub.
You are receiving this because you commented.
Christian Brabandt
I have improved the documentation and added a reference to :h W24 in the warning message
—
Reply to this email directly, view it on GitHub.
You are receiving this because you commented.
Luca Saccarola
LGTM!
—
Reply to this email directly, view it on GitHub.
You are receiving this because you commented.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you commented.