[vim/vim] Fix style and typo in documents (PR #15801)

9 views
Skip to first unread message

h_east

unread,
Oct 4, 2024, 2:48:27 PM10/4/24
to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/15801

Commit Summary

File Changes

(7 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15801@github.com>

zeertzjq

unread,
Oct 4, 2024, 7:00:57 PM10/4/24
to vim/vim, Subscribed

@zeertzjq commented on this pull request.


In runtime/doc/starting.txt:

> @@ -972,9 +973,9 @@ accordingly.  Vim proceeds in this order:
 	The |v:vim_did_enter| variable is set to 1.
 	The |VimEnter| autocommands are executed.
 
-The $MYVIMRC or $MYGVIMRC file will be set to the first found vimrc and/or
-gvimrc file while $MYVIMDIR is set to the users personal runtime directory
-'rtp' (typically the first entry in 'runtimepath').
+The $MYVIMRC or $MYGVIMRC environment variable will be set to the first found
⬇️ Suggested change
-The $MYVIMRC or $MYGVIMRC environment variable will be set to the first found
+The $MYVIMRC or $MYGVIMRC environment variables will be set to the first found


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15801/review/2349354422@github.com>

Gary Johnson

unread,
Oct 4, 2024, 7:37:10 PM10/4/24
to reply+ACY5DGCRKE2U6GKXZU...@reply.github.com, vim...@googlegroups.com
On 2024-10-04, zeertzjq wrote:
> @zeertzjq commented on this pull request.
>
> -------------------------------------------------------------------------------
>
> In runtime/doc/starting.txt:
>
> > @@ -972,9 +973,9 @@ accordingly. Vim proceeds in this order:
> The |v:vim_did_enter| variable is set to 1.
> The |VimEnter| autocommands are executed.
>
> -The $MYVIMRC or $MYGVIMRC file will be set to the first found vimrc and/or
> -gvimrc file while $MYVIMDIR is set to the users personal runtime directory
> -'rtp' (typically the first entry in 'runtimepath').
> +The $MYVIMRC or $MYGVIMRC environment variable will be set to the first found
>
> ⬇️ Suggested change
>
> -The $MYVIMRC or $MYGVIMRC environment variable will be set to the first found
> +The $MYVIMRC or $MYGVIMRC environment variables will be set to the first found

If the statement is about the $MYVIMRC and $MYGVIMRC environment
variables and not to only one of them, then the change should be:

-The $MYVIMRC or $MYGVIMRC environment variable will be set to the first found
+The $MYVIMRC and $MYGVIMRC environment variables will be set to the first found

Regards,
Gary

vim-dev ML

unread,
Oct 4, 2024, 7:37:38 PM10/4/24
to vim/vim, vim-dev ML, Your activity


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15801/c2394790469@github.com>

zeertzjq

unread,
Oct 4, 2024, 8:10:26 PM10/4/24
to vim/vim, vim-dev ML, Comment

Oh, I looked at the source code, and indeed only one of them will be set, so the change isn't needed.


Reply to this email directly, view it on GitHub.

You are receiving this because you commented.Message ID: <vim/vim/pull/15801/c2394807186@github.com>

Christian Brabandt

unread,
Oct 5, 2024, 10:58:14 AM10/5/24
to vim/vim, vim-dev ML, Comment

Closed #15801 via 738ebfe.


Reply to this email directly, view it on GitHub.

You are receiving this because you commented.Message ID: <vim/vim/pull/15801/issue_event/14528164856@github.com>

Reply all
Reply to author
Forward
0 new messages