Patch 9.0.1541

[Bram Moolenaar]

Patch 9.0.1541 (after 9.0.1536)
Problem: CI: sound dummy is disabled.
Solution: Make sound dummy work again. (closes #12380)
Files: .github/workflows/ci.yml


*** ../vim-9.0.1540/.github/workflows/ci.yml 2023-05-09 22:13:54.301928160 +0100
--- .github/workflows/ci.yml 2023-05-11 15:20:02.979695309 +0100
***************
*** 174,191 ****
sudo usermod -a -G audio "${USER}"
sudo bash ci/setup-xvfb.sh

! # FIXME: Temporarily disabled because of build errors
! # - name: Set up snd-dummy
! # if: (!(contains(matrix.extra, 'unittests') || contains(matrix.extra, 'vimtags')))
! # env:
! # DEST_DIR: ${{ env.TMPDIR }}/linux-modules-extra-${{ env.LINUX_VERSION }}
! # run: |
! # cd /lib/modules/${{ env.LINUX_VERSION }}
! # sudo apt-get install -d -y linux-modules-extra-${{ env.LINUX_VERSION }}
! # sudo dpkg -x /var/cache/apt/archives/linux-modules-extra-${{ env.LINUX_VERSION }}*.deb "${DEST_DIR}"
! # tar -cC "${DEST_DIR}"/lib/modules/${{ env.LINUX_VERSION }} kernel/sound | sudo tar -x
! # sudo depmod
! # sudo modprobe snd-dummy

- name: Check autoconf
if: contains(matrix.extra, 'unittests')
--- 174,194 ----
sudo usermod -a -G audio "${USER}"
sudo bash ci/setup-xvfb.sh

! - name: Set up snd-dummy
! if: (!(contains(matrix.extra, 'unittests') || contains(matrix.extra, 'vimtags')))
! env:
! DEST_DIR: ${{ env.TMPDIR }}/linux-modules-extra-${{ env.LINUX_VERSION }}
! run: |
! cd /lib/modules/${{ env.LINUX_VERSION }}
! if [ sudo apt-get install -d -y linux-modules-extra-${{ env.LINUX_VERSION }} 2>&1 | $(grep "Unable to locate package ") ]; then
! echo "Download of " linux-modules-extra-${{ env.LINUX_VERSION }} "failed continue anyway" exit 0
! else
! sudo apt-get install -d -y linux-modules-extra-${{ env.LINUX_VERSION }}
! sudo dpkg -x /var/cache/apt/archives/linux-modules-extra-${{ env.LINUX_VERSION }}*.deb "${DEST_DIR}"
! tar -cvC "${DEST_DIR}"/lib/modules/${{ env.LINUX_VERSION }} kernel/sound | sudo tar -x
! sudo depmod --verbose
! sudo modprobe --verbose snd-dummy
! fi

- name: Check autoconf
if: contains(matrix.extra, 'unittests')
*** ../vim-9.0.1540/src/version.c 2023-05-11 15:02:52.231456894 +0100
--- src/version.c 2023-05-11 15:21:30.027720374 +0100
***************
*** 697,698 ****
--- 697,700 ----
{ /* Add new patch number below this line */
+ /**/
+ 1541,
/**/

--
How To Keep A Healthy Level Of Insanity:
11. Specify that your drive-through order is "to go".

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Christian Brabandt]

On Do, 11 Mai 2023, Bram Moolenaar wrote:

>
> Patch 9.0.1541 (after 9.0.1536)
> Problem: CI: sound dummy is disabled.
> Solution: Make sound dummy work again. (closes #12380)
> Files: .github/workflows/ci.yml

I wondered if this is the best approach to silently skip loading the
sound dummy modules and then ci possibly no longer testing the sound
features, so we risk regressions. But I guess this is fine.

Best,
Christian
--
In nichts zeigt sich der Mangel an mathematischer Bildung mehr, als in
einer übertrieben genauen Rechnung.
-- Carl Friedrich Gauß

[Bram Moolenaar]

> > Patch 9.0.1541 (after 9.0.1536)
> > Problem: CI: sound dummy is disabled.
> > Solution: Make sound dummy work again. (closes #12380)
> > Files: .github/workflows/ci.yml
>
> I wondered if this is the best approach to silently skip loading the
> sound dummy modules and then ci possibly no longer testing the sound
> features, so we risk regressions. But I guess this is fine.

I'm open to suggestions for improvement. We don't want several actions
to fail whenever there is a version mismatch. But if the tests are
silently skipped for a longer time that also isn't good. Is tnere any
way for CI to report a problem when it happens many times or a number of
days in a row?

--
How To Keep A Healthy Level Of Insanity:

15. Five days in advance, tell your friends you can't attend their
party because you're not in the mood.