Strange patch 9.0.815

84 views
Skip to first unread message

Tony Mechelynck

unread,
Oct 22, 2022, 11:47:48 AM10/22/22
to Bram Moolenaar, Christian Brabandt, vim_dev
At least on the Mercurial server, patch 9.0.815 has no description of
the "problem", nor of the "solution", and it also hasn't got a
Mercurial tag.

Neither does it have a vim-dev message AFAICT.

Best regards,
Tony.

Marius Gedminas

unread,
Oct 22, 2022, 3:03:16 PM10/22/22
to vim...@googlegroups.com
On Sat, Oct 22, 2022 at 05:47:32PM +0200, Tony Mechelynck wrote:
> At least on the Mercurial server, patch 9.0.815 has no description of
> the "problem", nor of the "solution", and it also hasn't got a
> Mercurial tag.

Same on the Git server.

Also, the v9.0.0814 tag points to the same commit as v9.0.0813, and the
actual 9.0.0814 commit is untagged.

> Neither does it have a vim-dev message AFAICT.

I haven't seen one. But I have seen the segfaults introduced by it.

Marius Gedminas
--
/* Intel provided a special instruction to clear the TS bit for people too cool
* to use write_cr0() to do it. This "clts" instruction is faster, because all
* the vowels have been optimized out. */
-- lguest source code
signature.asc

Bram Moolenaar

unread,
Oct 24, 2022, 8:27:28 AM10/24/22
to vim...@googlegroups.com
I suppose the script that prepares the commit was missing a quote.  Just add the info from the email. 

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAJkCKXvNSHOdN0oPj98EFYcKW9qVt-syFQDN2LgRpEFShjAN%2Bw%40mail.gmail.com.

Bram Moolenaar

unread,
Oct 24, 2022, 8:27:29 AM10/24/22
to vim...@googlegroups.com
Well if there was no message either use the info i"ll send later when I am back home. I at first did not have them properly in git. Found the problem in th third while working on the second.

On Sat, Oct 22, 2022, 16:47 Tony Mechelynck <antoine.m...@gmail.com> wrote:

Bram Moolenaar

unread,
Oct 27, 2022, 5:05:32 PM10/27/22
to vim...@googlegroups.com, Marius Gedminas

> On Sat, Oct 22, 2022 at 05:47:32PM +0200, Tony Mechelynck wrote:
> > At least on the Mercurial server, patch 9.0.815 has no description of
> > the "problem", nor of the "solution", and it also hasn't got a
> > Mercurial tag.
>
> Same on the Git server.
>
> Also, the v9.0.0814 tag points to the same commit as v9.0.0813, and the
> actual 9.0.0814 commit is untagged.
>
> > Neither does it have a vim-dev message AFAICT.
>
> I haven't seen one. But I have seen the segfaults introduced by it.

Sorry, I had some trouble with the script I use to generate the git
commands, quotes in the text were not properly escaped. It's hard for
me now to fix the messages, if someone can quote me the git commands
literally I can execute them.

I had also lost some diffs of changes I made, for which I did describe
the problem and solution. I'll try to dig them up somehow.
See below for what notes I had about them.

If there are remaining problems caused by these patches, please create a
PR.

Please review the way I made the CTRL-Z at the end of the file preserved
like a missing EOL. Is this the right solution? I hadn't tested it
much, would have to get an MS-Windows system to try it out, which I
didn't... A better test would also be useful, I just edited the
existing test for EOL a bit, not sufficient.


These are the last notes that I have of these patches:

Patch 9.0.0814
Author: "Justin M. Keyes" <just...@gmail.com>
Summary: aws config files are not recognized
Problem: Aws config files are not recognized.
Solution: Use "confini" for aws config files. (Justin M. Keyes,
closes #11416)
Files: runtime/filetype.vim, src/testdir/test_filetype.vim

Patch 9.0.0815
Author: Martin Tournoij <mar...@arp242.net>
Summary: ":!" does not switch to the alternate screen
Problem: ":!" does not switch to the alternate screen.
Solution: For ":!" don't clear the previous command. (closes #11420,
closes #11409)
Files: runtime/doc/various.txt, src/ex_cmds.c, src/testdir/test_shell.vim

Patch 9.0.0816
Author:
Summary: CTRL-Z at end of file is always dropped
Problem: CTRL-Z at end of file is always dropped.
Solution: Add the 'endoffile' option, like the 'endofline' option.
(closes #11408, closes #11397)
Files: runtime/doc/options.txt, src/optiondefs.h, src/option.h,
src/structs.h, src/fileio.c, src/bufwrite.c,
src/testdir/test_fixeol.vim

Patch 9.0.0817 (after 9.0.0816)
Author:
Summary: build error
Problem: Build error.
Solution: correct variable name.
Files: src/bufwrite.c

Patch 9.0.0818 (after 9.0.0815)
Author:
Summary: "!ls" does not work
Problem: "!ls" does not work.
Solution: Do not free memory that is in use.
Files: src/ex_cmds.c


--
Why I like vim:
> I like VIM because, when I ask a question in this newsgroup, I get a
> one-line answer. With xemacs, I get a 1Kb lisp script with bugs in it ;-)

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
Reply all
Reply to author
Forward
0 new messages