[vim/vim] Do not run filetype detect for directories in netrw (PR #11290)
Teo Ljungberg
Resolves #9875
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/11290
Commit Summary
- 2275ce4 Do not run filetype detect for directories in netrw
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
I actually think there is never a point in "filetype detect" to try figure out the filetype for a directory.
Or we should just set filetype to "directory".
How about that? Would that break anything?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
Actually, it appears "filetype detect" already rejects directories. In the netrw plugin it uses a buffer to display the directory contents, but that buffer is not a directory itself.
Hmm, I have trouble reproducing the original problem. How do you get the filetype to be something else than "netrw"?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Maxim Kim
I guess this is related to #9099 which is easy to reproduce.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
OK, I'll include it. Let me close the other issues and leave this one open for Charles.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
> I guess this is related to https://github.com/vim/vim/issues/9099
> which is easy to reproduce.
--
This is an airconditioned room, do not open Windows.
/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Teo Ljungberg
I’ve reproduced this using :Explore and entering a directory under a .vim or .com and then bubbling back up to the parent directory, that corresponds to setting ft={vim,dcl} respectively - while it should be netrw.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Teo Ljungberg
Anything you need from me to push this forward @cecamp ?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Teo Ljungberg
@brammool While resolving the merge conflicts I saw that 3c053a1 was merged into master yesterday.
Which includes the gist of this patch.
Should we then close this PR?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
> @brammool While resolving the merge conflicts I saw that https://github.com/vim/vim/commit/3c053a1a5ad2a3c924929e11f2b9af20a8b901e2 was merged into master yesterday.
> Which includes the gist of this patch.
>
> Should we then close this PR?
Unfortunately I haven't heard much from him lately.
--
Beer & pretzels can't be served at the same time in any bar or restaurant.
[real standing law in North Dakota, United States of America]
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
Teo Ljungberg
I tested out 3c053a1 and what’s on main and it works as expected.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Teo Ljungberg
Closed #11290.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.