[vim/vim] [netrw] Fix file move when g:netrw_keepdir=0 (PR #10757)
Alexandre Lepretre
The function NetrwMarkFileMove didn't support g:netrw_keepdir=1.
I add a small if to prefix the path (heavily inspired by NetrwMarkFileCopy)
Related issues:
Could not find any test for this plugin
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/10757
Commit Summary
- 0ee7446 [netrw] Fix file move when g:netrw_keepdir=0
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Alexandre Lepretre
@Matsa59 pushed 1 commit.
- 8dc0cfb Merge branch 'vim:master' into master
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
codecov[bot]
Codecov Report
Merging #10757 (8dc0cfb) into master (be9fc5b) will decrease coverage by
81.45%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #10757 +/- ## =========================================== - Coverage 81.75% 0.29% -81.46% =========================================== Files 162 152 -10 Lines 188186 173825 -14361 Branches 42849 39997 -2852 =========================================== - Hits 153844 520 -153324 - Misses 21828 173248 +151420 + Partials 12514 57 -12457
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | ? |
|
| huge-gcc-none | ? |
|
| huge-gcc-testgui | ? |
|
| huge-gcc-unittests | 0.29% <ø> (ø) |
|
| linux | 0.29% <ø> (-82.17%) |
⬇️ |
| mingw-x64-HUGE | ? |
|
| mingw-x64-HUGE-gui | ? |
|
| windows | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/float.c | 0.00% <0.00%> (-98.42%) |
⬇️ |
| src/sha256.c | 0.00% <0.00%> (-96.45%) |
⬇️ |
| src/gui_gtk_f.c | 0.00% <0.00%> (-94.72%) |
⬇️ |
| src/arabic.c | 0.00% <0.00%> (-94.57%) |
⬇️ |
| src/crypt_zip.c | 0.00% <0.00%> (-94.12%) |
⬇️ |
| src/typval.c | 0.00% <0.00%> (-93.20%) |
⬇️ |
| src/blob.c | 0.00% <0.00%> (-92.46%) |
⬇️ |
| src/debugger.c | 0.00% <0.00%> (-92.23%) |
⬇️ |
| src/eval.c | 0.00% <0.00%> (-92.19%) |
⬇️ |
| src/vim9compile.c | 0.00% <0.00%> (-92.15%) |
⬇️ |
| ... and 146 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Alexandre Lepretre
I guess the macos CI is broken... for 4 lignes (one if) I don't think I change a lot of perf x)
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
> I guess the macos CI is broken... for 4 lignes (one if) I don't think
> I change a lot of perf x)
ongoing work.
--
hundred-and-one symptoms of being an internet addict:
51. You put a pillow case over your laptop so your lover doesn't see it while
you are pretending to catch your breath.
/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Charles Campbell
>
> @Matsa59 <https://github.com/Matsa59> pushed 1 commit.
>
> * 22bd830
> <https://github.com/vim/vim/commit/22bd8302b114d1ac7ad96a1297a362e97a04fb1c>
>
> —
> View it on GitHub
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACY5DGEBBTJDDZ7C4UNBDFTV6NQE7ANCNFSM537Y2LNA>.
>
>
Hello!
I'm netrw's maintainer; would you please send me a patch?
Thank you,
Chip Campbell
Bram Moolenaar
Charles wrote:
> Alexandre Lepretre (Vim Github Repository) wrote:
> >
> > @Matsa59 <https://github.com/Matsa59> pushed 1 commit.
> >
> > * 22bd830
> > Merge branch 'vim:master' into master
> >
> > View it on GitHub=20
> > <https://github.com/vim/vim/pull/10757/files/8dc0cfbb641e2c60a5259afb1f20=
> f97545bb5055..22bd8302b114d1ac7ad96a1297a362e97a04fb1c>=20
> > or unsubscribe=20
> > <https://github.com/notifications/unsubscribe-auth/ACY5DGEBBTJDDZ7C4UNBDF=
> TV6NQE7ANCNFSM537Y2LNA>.
> > You are receiving this because you are subscribed to this=20
> >
> >
> Hello!
>
> I'm netrw's maintainer; would you please send me a patch?
click-through way to get the diff or patch of a PR.
The only way I know is to grab the URL, up to and including the issue
number, and add ".diff". This in this case:
https://github.com/vim/vim/pull/10757.diff
If you add ".patch" you get the commits separately, and info about the
PR creator.
--
From "know your smileys":
:-| :-| Deja' vu!
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
Charles Campbell
>
> @Matsa59 <https://github.com/Matsa59> pushed 1 commit.
>
> <https://github.com/vim/vim/commit/af9a9d2735b8afb53895398289faf53de05c2e72>
>
>
-- but the fix was put into a windows-only if-endif block. So, I've
moved the older fix to handle all such actions (marked files move with
g:netrw_keepdir == 1).
Please try netrw v172g (which you can get from my website:
http://www.drchip.org/astronaut/vim/index.html#NETRW).
Thank you,
Chip Campbell
Christian Brabandt
this seems to have been included by 71badf9
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Closed #10757.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.